From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780E1C4361B for ; Wed, 9 Dec 2020 14:53:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4020A23406 for ; Wed, 9 Dec 2020 14:53:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732325AbgLIOxu (ORCPT ); Wed, 9 Dec 2020 09:53:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:52450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732059AbgLIOxu (ORCPT ); Wed, 9 Dec 2020 09:53:50 -0500 Date: Wed, 9 Dec 2020 15:54:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607525590; bh=IIfUJorqMDpBd82MCjqYNcMz9MwC1uE5ZYVW7orcYZA=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=FGSaiilLUwmBIk0rZNRQHTyvh3Pq8cwIuv2+x4lySFPBlsw3nnB7ukYH/xx7IV+TR 0pkv/O+hcpRqgLNnRWN0H0yWRrVM7Xb35jv6dSEGIJjRMCkOylEP9OGdvaskR07AFk mQDkK6kzaS8alz1L4U4JDzZ3a5GUrsAhnIvogNCM= From: Greg Kroah-Hartman To: Jim Cromie Cc: Jason Baron , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] dyndbg: fix use before null check Message-ID: References: <20201123184334.1777186-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123184334.1777186-1-jim.cromie@gmail.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Nov 23, 2020 at 11:43:34AM -0700, Jim Cromie wrote: > commit a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()") > > Above commit copies a string before checking for null pointer, fix > this, and add a pr_err. Also trim comment, and add return val info. The way you list the above commit is very odd, and hard to read and understand. How about something like: In commit a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()"), a string is copied before checking.... Also, when you say "also" in a patch, that is a HUGE flag that the commit needs to be broken up into multiple patches. Put the bugfix first, and then fix up the comment later, if it is not being changed for this fix. Also: > Fixes: a2d375eda771 You need the full information here, please write: Fixes: a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()") Can you fix all of that up and resend? thanks, greg k-h