From: Conor Dooley <conor@kernel.org>
To: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Cc: regressions@lists.linux.dev, stable@vger.kernel.org,
Eva Kotova <nyandarknessgirl@gmail.com>,
linux-riscv@lists.infradead.org, coelacanthus@outlook.com,
kernel-team@lists.ubuntu.com
Subject: Re: Regression: Fwd: Re: [PATCH] riscv: mmap with PROT_WRITE but no PROT_READ is invalid
Date: Tue, 11 Oct 2022 17:58:40 +0100 [thread overview]
Message-ID: <Y0WgwBgenhnk7/O2@spud> (raw)
In-Reply-To: <d6c9e249-08bd-4439-7dcc-371b32e7b851@canonical.com>
On Tue, Oct 11, 2022 at 05:52:13PM +0100, Dimitri John Ledkov wrote:
> #regzbot ^introduced 2139619bcad7ac44cc8f6f749089120594056613
>
> Over at https://lore.kernel.org/linux-riscv/Yz80ewHKTPI5Rvuz@spud/T/#ebde47064434d4ca4807b4abb8eb39898c48a8de2
> it is reported that 2139619bcad7ac44cc8f6f749089120594056613
> regresses userspace (openjdk) on riscv64.
>
> This commit has already been released in v6.0 kernel upstream,
> but has also been included in the stable patch series all the
> way back to v4.19.y
>
> There is a proposed fix for this at
> https://lore.kernel.org/linux-riscv/20220915193702.2201018-1-abrestic@rivosinc.com/
> which has not yet been merged upstream or in stable series.
>
> Please review and merge above proposed fix, or please revert
> 2139619bcad7ac44cc8f6f749089120594056613 to stop the regression
> spreading to all the distributions.
Out of curiosity, and given the CC list lacks a CC of the maintainer,
who are you actually asking to review and/or merge this?
I'll go bump the fix itself.
Thanks,
Conor.
>
> In Ubuntu this regression will be tracked as https://bugs.launchpad.net/bugs/+bug/1992484
>
> -------- Forwarded Message --------
> Subject: Re: [PATCH] riscv: mmap with PROT_WRITE but no PROT_READ is invalid
> Date: Thu, 6 Oct 2022 22:20:02 +0300
> From: Eva Kotova <nyandarknessgirl@gmail.com>
> Reply-To: PH7PR14MB559464DBDD310E755F5B21E8CEDC9@PH7PR14MB5594.namprd14.prod.outlook.com
> To: coelacanthus@outlook.com
> CC: c141028@gmail.com, dramforever@live.com, linux-riscv@lists.infradead.org, palmer@dabbelt.com, xc-tan@outlook.com
>
> On Tue, 31 May 2022 00:56:52 PDT (-0700), coelacanthus@outlook.com wrote:
> > As mentioned in Table 4.5 in RISC-V spec Volume 2 Section 4.3, write
> > but not read is "Reserved for future use.". For now, they are not valid.
> > In the current code, -wx is marked as invalid, but -w- is not marked
> > as invalid.
>
> This patch breaks OpenJDK/Java on RISC-V, as it tries to create a w-only
> protective page:
>
> #
> # There is insufficient memory for the Java Runtime Environment to continue.
> # Native memory allocation (mmap) failed to map 4096 bytes for failed to
> allocate memory for PaX check.
> # An error report file with more information is saved as:
> # /root/hs_err_pid107.log
>
> I bisected to this commit since on Linux 5.19+ java no longer works.
> Perhaps some fallback should be implemented, to prevent userspace
> breakage. It is currently documented, that at least on i386 PROT_WRITE
> mappings imply PROT_READ (See man mmap(2) NOTES), this would be a good
> place to start.
>
> Best regards,
> Eva
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>
next prev parent reply other threads:[~2022-10-11 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 16:52 Regression: Fwd: Re: [PATCH] riscv: mmap with PROT_WRITE but no PROT_READ is invalid Dimitri John Ledkov
2022-10-11 16:58 ` Conor Dooley [this message]
2022-10-11 17:18 ` Dimitri John Ledkov
2022-11-04 12:02 ` Regression: Fwd: Re: [PATCH] riscv: mmap with PROT_WRITE but no PROT_READ is invalid #forregzbot Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0WgwBgenhnk7/O2@spud \
--to=conor@kernel.org \
--cc=coelacanthus@outlook.com \
--cc=dimitri.ledkov@canonical.com \
--cc=kernel-team@lists.ubuntu.com \
--cc=linux-riscv@lists.infradead.org \
--cc=nyandarknessgirl@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).