From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E487C4321E for ; Fri, 11 Nov 2022 04:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbiKKEMC (ORCPT ); Thu, 10 Nov 2022 23:12:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231777AbiKKELi (ORCPT ); Thu, 10 Nov 2022 23:11:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB74E1BEB7; Thu, 10 Nov 2022 20:11:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7511DB823A6; Fri, 11 Nov 2022 04:11:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88540C433C1; Fri, 11 Nov 2022 04:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668139891; bh=cEEs+T9qWk3rROxF8lp+RSEHIzLb14TurbQZNI6Tbl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rEDTMvM3UUIKoGN9jTpfqNxfpOkSshWtW/miWmQBJhmXtj9qaQGjTwLIle3BqvZhv 79pAuSqmcjX2H8WCyuwoBx0RdC2q8BW6NGkokoiomC+p09cQQnYLq01ry1jbpcfWZy p4hmM0HvqBIUMY4OXScLLW0CIuriB6NPzEhywrppfPCS5ZB8fGqqcxCACS30aNZH3N z9tcgsptxBFjh3+vyKGJ4lauoztk0q3+JRk9YPOkjRlM3awQyJteeql1jqDlVHVvdK t/5tdvS0c3yTQxJvSx3v8sF1T6YepdWGV9NFcFmZ/KJrNcPr6U2tU3mPkEyr3nBnz+ I+XLn+R7lsf9w== Date: Fri, 11 Nov 2022 09:41:25 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: Bard Liao , stable@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, bard.liao@intel.com Subject: Re: [PATCH] soundwire: intel: Initialize clock stop timeout Message-ID: References: <20221020015624.1703950-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 09-11-22, 10:05, Pierre-Louis Bossart wrote: > > > On 10/28/22 06:28, Vinod Koul wrote: > > On 20-10-22, 09:56, Bard Liao wrote: > >> From: Sjoerd Simons > >> > >> The bus->clk_stop_timeout member is only initialized to a non-zero value > >> during the codec driver probe. This can lead to corner cases where this > >> value remains pegged at zero when the bus suspends, which results in an > >> endless loop in sdw_bus_wait_for_clk_prep_deprep(). > >> > >> Corner cases include configurations with no codecs described in the > >> firmware, or delays in probing codec drivers. > >> > >> Initializing the default timeout to the smallest non-zero value avoid this > >> problem and allows for the existing logic to be preserved: the > >> bus->clk_stop_timeout is set as the maximum required by all codecs > >> connected on the bus. > > > > Applied to fixes, thanks > > Thanks Vinod, was this sent to Greg/Linus? the last pull request I see > was for 6.1-rc1. > Arch Linux cherry-picked this patch but other distros did not, so quite > a few users are left with no audio card. https://git.kernel.org/torvalds/c/f014699cca9a9a28fbdc06a9225b54562154fc20 -- ~Vinod