stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Florian Westphal <fw@strlen.de>
Cc: stable@vger.kernel.org, pablo@netfilter.org, paulburton@kernel.org
Subject: Re: stable request: mips strncpy is broken
Date: Thu, 4 Mar 2021 14:26:17 +0100	[thread overview]
Message-ID: <YEDf+XYB/dl5vx0u@kroah.com> (raw)
In-Reply-To: <20210303172336.GF17911@breakpoint.cc>

On Wed, Mar 03, 2021 at 06:23:36PM +0100, Florian Westphal wrote:
> Hello,
> 
> Please consider queueing
> 
> commit 3c0be5849259b729580c23549330973a2dd513a2
> Author: Paul Burton <paulburton@kernel.org>
>  MIPS: Drop 32-bit asm string functions
> 
> The commit is part of 5.5-rc1.
> 
> We got a bug report about following nftables rule not matching
> even if it should on Linux 5.4.y mips32:
> 
>   meta iifname "br-vlan"
> 
> 'iifname' uses strncpy(..., IFNAMSIZ) to copy dev->name to the register.
> The MIPS asm function doesn't zero-pad the remaining bytes, but that is
> needed for the compare op to work reliably.
> 
> The reporter confirmed that this removal fixes the issue, the generic C
> version behaves as expected.
> 
> The patch doesn't apply cleanly to 5.4, there is a minor conflict
> related to FORTIFY macro, but its easily resolved as all code
> is removed.
> 
> I did not try earlier 4.4.y releases but I susepct they should also get
> this patch applied.
> 
> I can send a 5.4.y backport if thats preferred.

Please do, that way I know it is done correctly and has been tested.

And here I thought no one was actually using MIPS anymore :)

thanks,

greg k-h

  reply	other threads:[~2021-03-04 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 17:23 stable request: mips strncpy is broken Florian Westphal
2021-03-04 13:26 ` Greg KH [this message]
2021-03-04 13:43   ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEDf+XYB/dl5vx0u@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fw@strlen.de \
    --cc=pablo@netfilter.org \
    --cc=paulburton@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).