From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Muchun Song <songmuchun@bytedance.com>, stable@vger.kernel.org
Subject: Re: Linux 5.10.20
Date: Fri, 5 Mar 2021 07:45:32 +0100 [thread overview]
Message-ID: <YEHTjCVIoXW1PciT@kroah.com> (raw)
In-Reply-To: <4dac43f81dc390faa6e62de39ade373851dd6b84.camel@gmx.de>
On Fri, Mar 05, 2021 at 04:16:36AM +0100, Mike Galbraith wrote:
> Damn, I forgot all about this, and it has now has spread.
>
> f92bac3b141b8 kernel/printk/printk_safe.c (Sergey Senozhatsky 2016-12-27 23:16:05 +0900 267) void printk_safe_flush_on_panic(void)
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 268) {
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 269) /*
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 270) * Make sure that we could access the main ring buffer.
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 271) * Do not risk a double release when more CPUs are up.
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 272) */
> 554755be08fba kernel/printk/printk_safe.c (Sergey Senozhatsky 2018-05-30 16:03:50 +0900 273) if (raw_spin_is_locked(&logbuf_lock)) {
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 274) if (num_online_cpus() > 1)
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 275) return;
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 276)
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 277) debug_locks_off();
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 278) raw_spin_lock_init(&logbuf_lock);
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 279) }
> cf9b1106c81c4 kernel/printk/nmi.c (Petr Mladek 2016-05-20 17:00:42 -0700 280)
> eb9036b4cf4c0 kernel/printk/printk_safe.c (Muchun Song 2021-02-10 11:48:23 +0800 281) if (raw_spin_is_locked(&safe_read_lock)) {
> eb9036b4cf4c0 kernel/printk/printk_safe.c (Muchun Song 2021-02-10 11:48:23 +0800 282) if (num_online_cpus() > 1)
> eb9036b4cf4c0 kernel/printk/printk_safe.c (Muchun Song 2021-02-10 11:48:23 +0800 283) return;
> eb9036b4cf4c0 kernel/printk/printk_safe.c (Muchun Song 2021-02-10 11:48:23 +0800 284)
> eb9036b4cf4c0 kernel/printk/printk_safe.c (Muchun Song 2021-02-10 11:48:23 +0800 285) debug_locks_off();
> eb9036b4cf4c0 kernel/printk/printk_safe.c (Muchun Song 2021-02-10 11:48:23 +0800 286) raw_spin_lock_init(&safe_read_lock);
> eb9036b4cf4c0 kernel/printk/printk_safe.c (Muchun Song 2021-02-10 11:48:23 +0800 287) }
> eb9036b4cf4c0 kernel/printk/printk_safe.c (Muchun Song 2021-02-10 11:48:23 +0800 288)
>
> eb9036b4cf4c0 == 8a8109f303e2 upstream, and accidentally duplicated
> most of printk_safe_flush_on_panic().
I'm sorry, but I do not know what you are trying to say here at all.
What am I supposed to do?
confused,
greg k-h
next prev parent reply other threads:[~2021-03-05 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 11:01 Linux 5.10.20 Greg Kroah-Hartman
2021-03-04 11:01 ` Greg Kroah-Hartman
2021-03-05 3:16 ` Mike Galbraith
2021-03-05 6:45 ` Greg Kroah-Hartman [this message]
2021-03-05 7:01 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEHTjCVIoXW1PciT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=efault@gmx.de \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).