From: Greg KH <gregkh@linuxfoundation.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: stable@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net,
kabel@kernel.org
Subject: Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches
Date: Mon, 19 Apr 2021 14:05:18 +0200 [thread overview]
Message-ID: <YH1x/qt8wpOh0bvj@kroah.com> (raw)
In-Reply-To: <20210418131344.21024-1-pali@kernel.org>
On Sun, Apr 18, 2021 at 03:13:44PM +0200, Pali Rohár wrote:
> commit 1fe976d308acb6374c899a4ee8025a0a016e453e upstream.
>
> Since commit fee2d546414d ("net: phy: marvell: mv88e6390 temperature
> sensor reading"), Linux reports the temperature of Topaz hwmon as
> constant -75°C.
>
> This is because switches from the Topaz family (88E6141 / 88E6341) have
> the address of the temperature sensor register different from Peridot.
>
> This address is instead compatible with 88E1510 PHYs, as was used for
> Topaz before the above mentioned commit.
>
> Create a new mapping table between switch family and PHY ID for families
> which don't have a model number. And define PHY IDs for Topaz and Peridot
> families.
>
> Create a new PHY ID and a new PHY driver for Topaz's internal PHY.
> The only difference from Peridot's PHY driver is the HWMON probing
> method.
>
> Prior this change Topaz's internal PHY is detected by kernel as:
>
> PHY [...] driver [Marvell 88E6390] (irq=63)
>
> And afterwards as:
>
> PHY [...] driver [Marvell 88E6341 Family] (irq=63)
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> BugLink: https://github.com/globalscaletechnologies/linux/issues/1
> Fixes: fee2d546414d ("net: phy: marvell: mv88e6390 temperature sensor reading")
> Reviewed-by: Marek Behún <kabel@kernel.org>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> [pali: Backported to 5.4 version]
> ---
> This patch is backported to 5.4 version. Tested on Turris Mox with Topaz switch.
What about a 5.10 version?
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-19 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 12:17 FAILED: patch "[PATCH] net: phy: marvell: fix detection of PHY on Topaz switches" failed to apply to 5.4-stable tree gregkh
2021-04-18 12:23 ` gregkh
2021-04-18 13:13 ` [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches Pali Rohár
2021-04-19 12:05 ` Greg KH [this message]
2021-04-19 12:08 ` Pali Rohár
2021-04-19 12:35 ` Greg KH
2021-04-19 12:47 ` Pali Rohár
2021-04-19 12:56 ` Greg KH
2021-04-19 13:49 ` Pali Rohár
2021-04-19 14:31 ` Sasha Levin
-- strict thread matches above, loose matches on Subject: below --
2021-04-19 13:47 Pali Rohár
2021-04-19 14:10 ` Greg KH
2021-04-18 12:17 FAILED: patch "[PATCH] net: phy: marvell: fix detection of PHY on Topaz switches" failed to apply to 4.19-stable tree gregkh
2021-04-18 13:19 ` [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH1x/qt8wpOh0bvj@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=pali@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).