From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC27CC433ED for ; Fri, 16 Apr 2021 05:21:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F4B16113B for ; Fri, 16 Apr 2021 05:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234914AbhDPFVm (ORCPT ); Fri, 16 Apr 2021 01:21:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:39992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhDPFVh (ORCPT ); Fri, 16 Apr 2021 01:21:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3982B6113D; Fri, 16 Apr 2021 05:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618550473; bh=zCLuvAGeSVQtLqcXP3P3hweTU1KMAi/MpHFAgC7c6kA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2he4wh1zL4V1VmasGEnrinOYOudKZTaKpzQwcJukF0C6QjmsY83AnRsU85RRfIgU/ QlPCjzWCXC2QwytuQkTcTaQWrokTxaVi35UPtSeIaoX/W7hagpeUxBHp3H3g4fXctd 16yPLKN7bhIt0SF0TDiURA4gccmw6EudY0OLhJ9Q= Date: Fri, 16 Apr 2021 07:21:11 +0200 From: Greg Kroah-Hartman To: Guenter Roeck Cc: stable Subject: Re: netfilter/x_tables patches for v4.4.y..v4.14.y Message-ID: References: <1780f159-140b-231f-8af5-ccec049dc8b0@roeck-us.net> <20210415174146.GA30478@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210415174146.GA30478@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Apr 15, 2021 at 10:41:46AM -0700, Guenter Roeck wrote: > On Thu, Apr 15, 2021 at 06:37:41PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Apr 15, 2021 at 09:28:15AM -0700, Guenter Roeck wrote: > > > Hi Greg, > > > > > > please consider applying the following two patches to v4.4.y, v4.9.y, and v4.14.y > > > > > > 80055dab5de0 ("netfilter: x_tables: make xt_replace_table wait until old rules are not used anymore") > > > 175e476b8cdf ("netfilter: x_tables: Use correct memory barriers.") > > > > The second patch here says that it's only needed to go back until: > > Fixes: 7f5c6d4f665b ("netfilter: get rid of atomic ops in fast path") > > > > Which is only backported to 4.19. So why do older kernels need that, is > > the fixes tag wrong? > > > Where do you get that from ? 7f5c6d4f665b is, from what I can see, in v3.0. > > $ git describe 7f5c6d4f665b > v2.6.39-rc1-159-g7f5c6d4f665b > $ git log --oneline v2.6.39..v3.0 | grep "netfilter: get rid of atomic ops in fast path" > 7f5c6d4f665b netfilter: get rid of atomic ops in fast path Ah, my tool that checks where a patch comes from doesn't look past 3.1 if it finds that it was mentioned in a released tree for various reasons, but when I look at the full sha1, it finds it properly, my fault... thanks, greg k-h