From: Sasha Levin <sashal@kernel.org>
To: Jianxiong Gao <jxgao@google.com>
Cc: Greg KH <greg@kroah.com>, stable@vger.kernel.org, marcorr@google.com
Subject: Re: [PATCH v5.10 0/8] preserve DMA offsets when using swiotlb
Date: Wed, 28 Apr 2021 12:18:19 -0400 [thread overview]
Message-ID: <YImKy+EW2EzMR7x0@sashalap> (raw)
In-Reply-To: <CAMGD6P3SY=BeXjKAajCiHXXRXzLMnDiPo8weagJVurY_Ew0T2w@mail.gmail.com>
On Mon, Apr 26, 2021 at 11:00:56AM -0700, Jianxiong Gao wrote:
>On Sat, Apr 24, 2021 at 7:43 AM Greg KH <greg@kroah.com> wrote:
>> Ok, and what prevents you from adding this new feature do your "custom"
>> kernel, or to use 5.12 instead?
>>
>> This is a new feature that Linux has never supported, and these patches
>> are not "trivial" at all. I also do not see the maintainer of the
>> subsystem agreeing that these are needed to be backported, which is not
>> a good sign.
>>
>So this is not about a new feature. This is about an existing bug that
>we stumbled onto while using SEV virtualization. However SEV is not
>needed to trigger the bug. We have reproduced the bug with just
>NVMe + SWIOTLB=force option in Rhel 8 environment. Please note
>that NVMe and SWIOTLB=force are both existing feature and without
>the patch they don't work together. This is why we are proposing to merge
>the patches into the LTS kernels.
Could you re-spin this series with the comments around patch formatting
addressed, and explicitly cc hch on this to get his ack?
--
Thanks,
Sasha
prev parent reply other threads:[~2021-04-28 16:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 21:02 [PATCH v5.10 0/8] preserve DMA offsets when using swiotlb Jianxiong Gao
2021-04-05 21:02 ` [PATCH v5.10 1/8] driver core: add a min_align_mask field to struct device_dma_parameters Jianxiong Gao
2021-04-07 12:50 ` Greg KH
2021-04-05 21:02 ` [PATCH v5.10 2/8] swiotlb: factor out an io_tlb_offset helper Jianxiong Gao
2021-04-05 21:02 ` [PATCH v5.10 3/8] swiotlb: factor out a nr_slots helper Jianxiong Gao
2021-04-05 21:02 ` [PATCH v5.10 4/8] swiotlb: clean up swiotlb_tbl_unmap_single Jianxiong Gao
2021-04-05 21:02 ` [PATCH v5.10 5/8] swiotlb: refactor swiotlb_tbl_map_single Jianxiong Gao
2021-04-05 21:02 ` [PATCH v5.10 6/8] swiotlb: don't modify orig_addr in swiotlb_tbl_sync_single Jianxiong Gao
2021-04-05 21:02 ` [PATCH v5.10 7/8] swiotlb: respect min_align_mask Jianxiong Gao
2021-04-05 21:02 ` [PATCH v5.10 8/8] nvme-pci: set min_align_mask Jianxiong Gao
2021-04-07 12:51 ` [PATCH v5.10 0/8] preserve DMA offsets when using swiotlb Greg KH
2021-04-20 23:38 ` Jianxiong Gao
2021-04-23 15:14 ` Greg KH
2021-04-23 17:28 ` Jianxiong Gao
2021-04-23 22:10 ` Jianxiong Gao
2021-04-23 22:33 ` Marc Orr
2021-04-24 14:43 ` Greg KH
2021-04-26 18:00 ` Jianxiong Gao
2021-04-28 16:18 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YImKy+EW2EzMR7x0@sashalap \
--to=sashal@kernel.org \
--cc=greg@kroah.com \
--cc=jxgao@google.com \
--cc=marcorr@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).