From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D0FC432BE for ; Wed, 1 Sep 2021 08:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8C6A61054 for ; Wed, 1 Sep 2021 08:18:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243047AbhIAIS7 (ORCPT ); Wed, 1 Sep 2021 04:18:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:58632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242911AbhIAIS6 (ORCPT ); Wed, 1 Sep 2021 04:18:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A9F8760698; Wed, 1 Sep 2021 08:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630484282; bh=GN6JRgy0rHxRTizsSUkISXXfC+FJ/NBJUSoc2dRDr7g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xIZkGOmGCE/bunr/cFptL+5FjMPJ7LXz1r467yWZRHpobP/JKN4rq8eN8UcfHwo5T y8LATeNg6XgS82riUxzVxhzN3vD/httFgED35ka2QI/ZXDhPRqc1O7l733i9624Xtm BFnK5IA+FW6ejqllALDbXeFkwzPqX3HZd6eNTjlQ= Date: Wed, 1 Sep 2021 10:17:59 +0200 From: Greg Kroah-Hartman To: Frieder Schrempf Cc: Miquel Raynal , Frieder Schrempf , stable@vger.kernel.org, voice INTER connect GmbH , Alexander Lobakin , Felix Fietkau , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Richard Weinberger , YouChing Lin Subject: Re: [PATCH v2 5.10.x] mtd: spinand: Fix incorrect parameters for on-die ECC Message-ID: References: <20210830130211.445728-1-frieder@fris.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210830130211.445728-1-frieder@fris.de> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Aug 30, 2021 at 03:02:10PM +0200, Frieder Schrempf wrote: > From: Frieder Schrempf > > The new generic NAND ECC framework stores the configuration and > requirements in separate places since commit 93ef92f6f422 ("mtd: nand: Use > the new generic ECC object"). In 5.10.x The SPI NAND layer still uses only > the requirements to track the ECC properties. This mismatch leads to > values of zero being used for ECC strength and step_size in the SPI NAND > layer wherever nanddev_get_ecc_conf() is used and therefore breaks the SPI > NAND on-die ECC support in 5.10.x. > > By using nanddev_get_ecc_requirements() instead of nanddev_get_ecc_conf() > for SPI NAND, we make sure that the correct parameters for the detected > chip are used. In later versions (5.11.x) this is fixed anyway with the > implementation of the SPI NAND on-die ECC engine. > > Cc: stable@vger.kernel.org # 5.10.x > Reported-by: voice INTER connect GmbH > Signed-off-by: Frieder Schrempf > Acked-by: Miquel Raynal > --- > Changes in v2: > * Fix checkpatch error/warnings for commit message style > * Add Miquel's A-b tag Now queued up, thanks. greg k-h