From: Greg KH <gregkh@linuxfoundation.org>
To: Thomas Perrot <thomas.perrot@bootlin.com>
Cc: linux-spi@vger.kernel.org, broonie@kernel.org,
linus.walleij@linaro.org, stable@vger.kernel.org
Subject: Re: [PATCH] spi: spl022: fix Microwire full duplex mode
Date: Fri, 22 Oct 2021 16:34:44 +0200 [thread overview]
Message-ID: <YXLMBPje3zMPYH8S@kroah.com> (raw)
In-Reply-To: <20211022142104.1386379-1-thomas.perrot@bootlin.com>
On Fri, Oct 22, 2021 at 04:21:04PM +0200, Thomas Perrot wrote:
> There are missing braces in the function that verify controller parameters,
> then an error is always returned when the parameter to select Microwire
> frames operation is used on devices allowing it.
>
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
> drivers/spi/spi-pl022.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index feebda66f56e..e4484ace584e 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -1716,12 +1716,13 @@ static int verify_controller_parameters(struct pl022 *pl022,
> return -EINVAL;
> }
> } else {
> - if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX)
> + if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX) {
> dev_err(&pl022->adev->dev,
> "Microwire half duplex mode requested,"
> " but this is only available in the"
> " ST version of PL022\n");
> - return -EINVAL;
> + return -EINVAL;
> + }
> }
> }
> return 0;
> --
> 2.31.1
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2021-10-22 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 14:21 [PATCH] spi: spl022: fix Microwire full duplex mode Thomas Perrot
2021-10-22 14:34 ` Greg KH [this message]
2021-10-23 11:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXLMBPje3zMPYH8S@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.perrot@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).