From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ricardo Ribalda <ricardo.ribalda@gmail.com>
Cc: Nicolas Dufresne <nicolas@ndufresne.ca>,
": Ricardo Ribalda" <ribalda@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
tfiga@chromium.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/3] media: v4l2-dev.c: Allow driver-defined entity names
Date: Tue, 7 Dec 2021 02:15:21 +0200 [thread overview]
Message-ID: <Ya6nmXKvTqhMVToH@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20211207000629.4985-3-ribalda@chromium.org>
Hi Ricardo,
Thank you for the patch.
On Tue, Dec 07, 2021 at 01:06:28AM +0100, Ricardo Ribalda wrote:
> If the driver provides an name for an entity, use it.
> This is particularly useful for drivers that export multiple video
> devices for the same hardware (i.e. metadata and data).
This seems reasonable (especially given that I've proposed it), but I
may be missing unintented consequences. Other reviews would be useful.
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/media/v4l2-core/v4l2-dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-dev.c b/drivers/media/v4l2-core/v4l2-dev.c
> index d03ace324db0..4c00503b9349 100644
> --- a/drivers/media/v4l2-core/v4l2-dev.c
> +++ b/drivers/media/v4l2-core/v4l2-dev.c
> @@ -832,7 +832,9 @@ static int video_register_media_controller(struct video_device *vdev)
> }
>
> if (vdev->entity.function != MEDIA_ENT_F_UNKNOWN) {
> - vdev->entity.name = vdev->name;
> + /* Use entity names provided by the driver, if available. */
> + if (!vdev->entity.name)
> + vdev->entity.name = vdev->name;
We need to document this.
>
> /* Needed just for backward compatibility with legacy MC API */
> vdev->entity.info.dev.major = VIDEO_MAJOR;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-12-07 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 0:06 [PATCH 0/3] uvc: Restore old vdev name Ricardo Ribalda
2021-12-07 0:06 ` [PATCH 1/3] Revert "media: uvcvideo: Set unique vdev name based in type" Ricardo Ribalda
2021-12-07 0:14 ` Laurent Pinchart
2021-12-07 0:18 ` Laurent Pinchart
2021-12-07 0:06 ` [PATCH 2/3] media: v4l2-dev.c: Allow driver-defined entity names Ricardo Ribalda
2021-12-07 0:15 ` Laurent Pinchart [this message]
2021-12-07 0:06 ` [PATCH 3/3] media: uvcvideo: Set unique entity name based in type Ricardo Ribalda
2021-12-07 0:16 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya6nmXKvTqhMVToH@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=ribalda@chromium.org \
--cc=ricardo.ribalda@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).