From: Mike Rapoport <rppt@kernel.org>
To: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
Cc: stable@vger.kernel.org, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux@armlinux.org.uk, rppt@linux.ibm.com, tony@atomide.com,
wangkefeng.wang@huawei.com, yj.chiang@mediatek.com
Subject: Re: [PATCH 5.4 1/5] memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER
Date: Mon, 13 Dec 2021 12:31:05 +0200 [thread overview]
Message-ID: <Ybcg6ZmQCSLbsy17@kernel.org> (raw)
In-Reply-To: <20211213085710.28962-2-mark-pk.tsai@mediatek.com>
On Mon, Dec 13, 2021 at 04:57:06PM +0800, Mark-PK Tsai wrote:
> Subject: [PATCH 5.4 1/5] memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER
I'd replace memblock: with arm: in the subject. I believe it's clearer this
way.
The same applies for the second patch in the series and for 5.10 posting.
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> commit e2a86800d58639b3acde7eaeb9eb393dca066e08 upstream.
>
> The code that frees unused memory map uses rounds start and end of the
> holes that are freed to MAX_ORDER_NR_PAGES to preserve continuity of the
> memory map for MAX_ORDER regions.
>
> Lots of core memory management functionality relies on homogeneity of the
> memory map within each pageblock which size may differ from MAX_ORDER in
> certain configurations.
>
> Although currently, for the architectures that use free_unused_memmap(),
> pageblock_order and MAX_ORDER are equivalent, it is cleaner to have common
> notation thought mm code.
>
> Replace MAX_ORDER_NR_PAGES with pageblock_nr_pages and update the comments
> to make it more clear why the alignment to pageblock boundaries is
> required.
>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> Tested-by: Tony Lindgren <tony@atomide.com>
> Link: https://lore.kernel.org/lkml/20210630071211.21011-1-rppt@kernel.org/
> [backport upstream modification in mm/memblock.c to arch/arm/mm/init.c]
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
> arch/arm/mm/init.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 7ea4d3b43444..6905dd8bc03f 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -381,11 +381,11 @@ static void __init free_unused_memmap(void)
> ALIGN(prev_end, PAGES_PER_SECTION));
> #else
> /*
> - * Align down here since the VM subsystem insists that the
> - * memmap entries are valid from the bank start aligned to
> - * MAX_ORDER_NR_PAGES.
> + * Align down here since many operations in VM subsystem
> + * presume that there are no holes in the memory map inside
> + * a pageblock
> */
> - start = round_down(start, MAX_ORDER_NR_PAGES);
> + start = round_down(start, pageblock_nr_pages);
> #endif
> /*
> * If we had a previous bank, and there is a space
> @@ -395,12 +395,12 @@ static void __init free_unused_memmap(void)
> free_memmap(prev_end, start);
>
> /*
> - * Align up here since the VM subsystem insists that the
> - * memmap entries are valid from the bank end aligned to
> - * MAX_ORDER_NR_PAGES.
> + * Align up here since many operations in VM subsystem
> + * presume that there are no holes in the memory map inside
> + * a pageblock
> */
> prev_end = ALIGN(memblock_region_memory_end_pfn(reg),
> - MAX_ORDER_NR_PAGES);
> + pageblock_nr_pages);
> }
>
> #ifdef CONFIG_SPARSEMEM
> --
> 2.18.0
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-12-13 10:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 8:57 [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map Mark-PK Tsai
2021-12-13 8:57 ` [PATCH 5.4 1/5] memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER Mark-PK Tsai
2021-12-13 10:31 ` Mike Rapoport [this message]
2021-12-13 8:57 ` [PATCH 5.4 2/5] memblock: align freed memory map on pageblock boundaries with SPARSEMEM Mark-PK Tsai
2021-12-13 8:57 ` [PATCH 5.4 3/5] memblock: ensure there is no overflow in memblock_overlaps_region() Mark-PK Tsai
2021-12-13 8:57 ` [PATCH 5.4 4/5] arm: extend pfn_valid to take into account freed memory map alignment Mark-PK Tsai
2021-12-13 8:57 ` [PATCH 5.4 5/5] arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM Mark-PK Tsai
2021-12-13 9:07 ` [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map Greg KH
2021-12-15 14:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybcg6ZmQCSLbsy17@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mark-pk.tsai@mediatek.com \
--cc=rppt@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).