From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@linux.intel.com
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
ak@linux.intel.com, damarion@cisco.com,
edison_chan_gz@hotmail.com, ray.kinsella@intel.com,
stable@vger.kernel.org
Subject: Re: [PATCH] perf/x86/intel: Add a quirk for the calculation of the number of counters on Alder Lake
Date: Wed, 12 Jan 2022 10:54:16 +0100 [thread overview]
Message-ID: <Yd6lSH41fqcpUS+P@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1641925238-149288-1-git-send-email-kan.liang@linux.intel.com>
On Tue, Jan 11, 2022 at 10:20:38AM -0800, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> For some Alder Lake machine with all E-cores disabled in a BIOS, the
> below warning may be triggered.
>
> [ 2.010766] hw perf events fixed 5 > max(4), clipping!
>
> Current perf code relies on the CPUID leaf 0xA and leaf 7.EDX[15] to
> calculate the number of the counters and follow the below assumption.
>
> For a hybrid configuration, the leaf 7.EDX[15] (X86_FEATURE_HYBRID_CPU)
> is set. The leaf 0xA only enumerate the common counters. Linux perf has
> to manually add the extra GP counters and fixed counters for P-cores.
> For a non-hybrid configuration, the X86_FEATURE_HYBRID_CPU should not
> be set. The leaf 0xA enumerates all counters.
>
> However, that's not the case when all E-cores are disabled in a BIOS.
> Although there are only P-cores in the system, the leaf 7.EDX[15]
> (X86_FEATURE_HYBRID_CPU) is still set. But the leaf 0xA is updated
> to enumerate all counters of P-cores. The inconsistency triggers the
> warning.
>
> Several software ways were considered to handle the inconsistency.
> - Drop the leaf 0xA and leaf 7.EDX[15] CPUID enumeration support.
> Hardcode the number of counters. This solution may be a problem for
> virtualization. A hypervisor cannot control the number of counters
> in a Linux guest via changing the guest CPUID enumeration anymore.
> - Find another CPUID bit that is also updated with E-cores disabled.
> There may be a problem in the virtualization environment too. Because
> a hypervisor may disable the feature/CPUID bit.
> - The P-cores have a maximum of 8 GP counters and 4 fixed counters on
> ADL. The maximum number can be used to detect the case.
> This solution is implemented in this patch.
ARGH!! This is horrific :-(
This is also the N-th problem with hybrid enumeration; is there a plan
to fix all that for the next generation or are we going to keep muddling
things?
> Fixes: ee72a94ea4a6 ("perf/x86/intel: Fix fixed counter check warning for some Alder Lake")
> Reported-by: Damjan Marion (damarion) <damarion@cisco.com>
> Tested-by: Damjan Marion (damarion) <damarion@cisco.com>
> Reported-by: Chan Edison <edison_chan_gz@hotmail.com>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Cc: stable@vger.kernel.org
> ---
> arch/x86/events/intel/core.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
> index 187906e..f1201e8 100644
> --- a/arch/x86/events/intel/core.c
> +++ b/arch/x86/events/intel/core.c
> @@ -6239,6 +6239,18 @@ __init int intel_pmu_init(void)
> pmu->num_counters = x86_pmu.num_counters;
> pmu->num_counters_fixed = x86_pmu.num_counters_fixed;
> }
> +
> + /* Quirk: For some Alder Lake machine, when all E-cores are disabled in
> + * a BIOS, the leaf 0xA will enumerate all counters of P-cores. However,
> + * the X86_FEATURE_HYBRID_CPU is still set. The above codes will
> + * mistakenly add extra counters for P-cores. Correct the number of
> + * counters here.
> + */
I fixed that comment style for you.
> + if ((pmu->num_counters > 8) || (pmu->num_counters_fixed > 4)) {
> + pmu->num_counters = x86_pmu.num_counters;
> + pmu->num_counters_fixed = x86_pmu.num_counters_fixed;
> + }
> +
> pmu->max_pebs_events = min_t(unsigned, MAX_PEBS_EVENTS, pmu->num_counters);
> pmu->unconstrained = (struct event_constraint)
> __EVENT_CONSTRAINT(0, (1ULL << pmu->num_counters) - 1,
> --
> 2.7.4
>
next prev parent reply other threads:[~2022-01-12 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 18:20 [PATCH] perf/x86/intel: Add a quirk for the calculation of the number of counters on Alder Lake kan.liang
2022-01-12 9:54 ` Peter Zijlstra [this message]
2022-01-12 15:26 ` Liang, Kan
2022-01-18 11:17 ` [tip: perf/urgent] " tip-bot2 for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd6lSH41fqcpUS+P@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=damarion@cisco.com \
--cc=edison_chan_gz@hotmail.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ray.kinsella@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).