From: Greg KH <gregkh@linuxfoundation.org>
To: Alexander Aring <alex.aring@gmail.com>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wpan - ML <linux-wpan@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
"# 3.19.x" <stable@vger.kernel.org>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH RFT] ieee802154: atusb: move to new USB API
Date: Mon, 3 Jan 2022 14:04:24 +0100 [thread overview]
Message-ID: <YdL0WHrRZpz9tJjX@kroah.com> (raw)
In-Reply-To: <CAB_54W6i9-fy8Vc-uypXPtj3Uy0VuZpidFuRH0DVoWJ8utcWiw@mail.gmail.com>
On Sun, Jan 02, 2022 at 05:15:38PM -0500, Alexander Aring wrote:
> Hi,
>
> On Sun, 2 Jan 2022 at 12:19, Pavel Skripkin <paskripkin@gmail.com> wrote:
> >
> > Alexander reported a use of uninitialized value in
> > atusb_set_extended_addr(), that is caused by reading 0 bytes via
> > usb_control_msg().
> >
>
> Does there exist no way to check on this and return an error on USB
> API caller level?
>
> > Since there is an API, that cannot read less bytes, than was requested,
> > let's move atusb driver to use it. It will fix all potintial bugs with
> > uninit values and make code more modern
> >
>
> If this is not possible to fix with the "old" USB API then I think the
> "old" USB API needs to be fixed.
We can not get rid of the "old" api calls, as sometimes they are needed
for some corner cases where you want to know if you read/wrote a
shorter/larger message than expected.
> Changing to the new USB API as "making the code more modern" is a new
> feature and is a candidate for next.
Fixing bugs is a good thing to do no matter when it happens.
thanks,
greg k-h
next prev parent reply other threads:[~2022-01-03 13:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAG_fn=VDEoQx5c7XzWX1yaYBd5y5FrG1aagrkv+SZ03c8TfQYQ@mail.gmail.com>
2022-01-02 17:19 ` [PATCH RFT] ieee802154: atusb: move to new USB API Pavel Skripkin
2022-01-02 22:15 ` Alexander Aring
2022-01-02 22:21 ` Pavel Skripkin
2022-01-02 22:36 ` Alexander Aring
2022-01-03 13:04 ` Greg KH [this message]
2022-01-03 13:03 ` Greg KH
2022-01-03 15:35 ` Alexander Aring
2022-01-04 19:41 ` Stefan Schmidt
2022-01-05 8:08 ` Greg KH
2022-01-05 9:01 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdL0WHrRZpz9tJjX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=glider@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=stable@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).