archive mirror
 help / color / mirror / Atom feed
From: dann frazier <>
To: Rob Herring <>
Cc: "Toan Le" <>,
	"Lorenzo Pieralisi" <>,
	"Krzysztof Wilczyński" <>,
	"Bjorn Helgaas" <>,
	"Andrew Murray" <>,
	"Stéphane Graber" <>,,,,
Subject: Re: [PATCH] PCI: xgene: Fix IB window setup
Date: Fri, 4 Feb 2022 16:01:32 -0700	[thread overview]
Message-ID: <Yf2wTLjmcRj+AbDv@xps13.dannf> (raw)
In-Reply-To: <>

On Mon, Nov 29, 2021 at 11:36:37AM -0600, Rob Herring wrote:
> Commit 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup")
> broke PCI support on XGene. The cause is the IB resources are now sorted
> in address order instead of being in DT dma-ranges order. The result is
> which inbound registers are used for each region are swapped. I don't
> know the details about this h/w, but it appears that IB region 0
> registers can't handle a size greater than 4GB. In any case, limiting
> the size for region 0 is enough to get back to the original assignment
> of dma-ranges to regions.

hey Rob!

I've been seeing a panic on HP Moonshoot m400 cartridges (X-Gene1) -
only during network installs - that I also bisected down to commit
6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup"). I was
hoping that this patch that fixed the issue on Stéphane's X-Gene2
system would also fix my issue, but no luck. In fact, it seems to just
makes it fail differently. Reverting both patches is required to get a
v5.17-rc kernel to boot.

I've collected the following logs - let me know if anything else would
be useful.

1) v5.17-rc2+ (unmodified):
   Note that the mlx4 driver fails initialization.

2) v5.17-rc2+, w/o the commit that fixed Stéphane's system:
   Note the mlx4 MSI-X timeout, and later panic.

3) v5.17-rc2+, w/ both commits reverted (works)


  parent reply	other threads:[~2022-02-04 23:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 17:36 Rob Herring
2021-11-29 19:14 ` Stéphane Graber
2021-11-30  7:55 ` Krzysztof Wilczyński
2021-11-30 14:30 ` Lorenzo Pieralisi
2022-02-04 23:01 ` dann frazier [this message]
2022-02-05 16:05   ` Rob Herring
2022-02-05 21:12     ` dann frazier
2022-02-07 16:09       ` Rob Herring
2022-02-08  1:19         ` dann frazier
2022-02-08 14:34           ` Rob Herring
2022-02-11  2:16             ` dann frazier
2022-02-21 11:50               ` Thorsten Leemhuis
2022-02-06  9:52   ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yf2wTLjmcRj+AbDv@xps13.dannf \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] PCI: xgene: Fix IB window setup' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).