archive mirror
 help / color / mirror / Atom feed
From: Greg KH <>
To: Oliver Hartkopp <>
Cc:, Thomas Wagner <>,
	Marc Kleine-Budde <>
Subject: Re: [BACKPORT stable Linux-5.10.y 2/2] can: isotp: add SF_BROADCAST support for functional addressing
Date: Thu, 17 Feb 2022 19:58:30 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Feb 16, 2022 at 07:31:37AM +0100, Oliver Hartkopp wrote:
> Upstream commit 921ca574cd382142add8b12d0a7117f495510de5
> The patch was intended for 5.10 but missed the merge window by some days.
> This missing patch continously breaks the backport of stable fixes and is
> the only missing feature of upstream isotp in Linux 5.10 e.g. for RasPi.
> socket is switched into functional addressing mode, where only single frame
> (SF) protocol data units can be send on the specified CAN interface and the
> given tp.tx_id after bind().
> In opposite to normal and extended addressing this socket does not register a
> CAN-ID for reception which would be needed for a 1-to-1 ISOTP connection with a
> segmented bi-directional data transfer.
> Sending SFs on this socket is therefore a TX-only 'broadcast' operation.
> Signed-off-by: Oliver Hartkopp <>
> Signed-off-by: Thomas Wagner <>
> Link:
> Signed-off-by: Marc Kleine-Budde <>
> ---
>  include/uapi/linux/can/isotp.h |  2 +-
>  net/can/isotp.c                | 50 ++++++++++++++++++++++++----------
>  2 files changed, 37 insertions(+), 15 deletions(-)

Both now queued up, thanks.

greg k-h

      reply	other threads:[~2022-02-17 18:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16  6:31 [BACKPORT stable Linux-5.10.y 1/2] can: isotp: prevent race between isotp_bind() and isotp_setsockopt() Oliver Hartkopp
2022-02-16  6:31 ` [BACKPORT stable Linux-5.10.y 2/2] can: isotp: add SF_BROADCAST support for functional addressing Oliver Hartkopp
2022-02-17 18:58   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).