From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrei Vagin <avagin@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Maxim Levitsky <mlevitsk@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 5.15] KVM: x86/mmu: kvm_faultin_pfn has to return false if pfh is returned
Date: Sat, 12 Mar 2022 14:11:58 +0100 [thread overview]
Message-ID: <YiycHmFtApPb2Zli@kroah.com> (raw)
In-Reply-To: <20220311081333.3855-1-avagin@gmail.com>
On Fri, Mar 11, 2022 at 12:13:33AM -0800, Andrei Vagin wrote:
> [ Upstream commit a7cc099f2ec3117678adeb69749bef7e9dde3148 ]
>
> This looks like a typo in 8f32d5e563cb. This change didn't intend to do
> any functional changes.
>
> The problem was caught by gVisor tests.
>
> Fixes: 8f32d5e563cb ("KVM: x86/mmu: allow kvm_faultin_pfn to return page fault handling code")
> Cc: Maxim Levitsky <mlevitsk@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Andrei Vagin <avagin@gmail.com>
> Message-Id: <20211015163221.472508-1-avagin@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/x86/kvm/mmu/mmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index 2297dd90fe4a..d6579bae25ca 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -3967,6 +3967,7 @@ static bool kvm_faultin_pfn(struct kvm_vcpu *vcpu, bool prefault, gfn_t gfn,
>
> *pfn = __gfn_to_pfn_memslot(slot, gfn, false, NULL,
> write, writable, hva);
> + return false;
>
> out_retry:
> *r = RET_PF_RETRY;
> --
> 2.35.1
>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-03-12 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 8:13 [PATCH 5.15] KVM: x86/mmu: kvm_faultin_pfn has to return false if pfh is returned Andrei Vagin
2022-03-12 13:11 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiycHmFtApPb2Zli@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=avagin@gmail.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).