From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Thorsten Leemhuis" <regressions@leemhuis.info>,
"José Expósito" <jose.exposito89@gmail.com>,
"Jiri Kosina" <jkosina@suse.cz>, "Takashi Iwai" <tiwai@suse.de>,
"Peter Hutterer" <peter.hutterer@who-t.net>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
"3.8+" <stable@vger.kernel.org>,
regressions@lists.linux.dev, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"
Date: Wed, 30 Mar 2022 21:13:30 -0700 [thread overview]
Message-ID: <YkUqajiNZmi+lAPC@google.com> (raw)
In-Reply-To: <CAO-hwJJweSuSBE_18ZbvqS12eX9GcS+aJoe7SRFJdASOrN3bqw@mail.gmail.com>
On Wed, Mar 30, 2022 at 02:30:37PM +0200, Benjamin Tissoires wrote:
> On Wed, Mar 30, 2022 at 2:27 PM Thorsten Leemhuis
> <regressions@leemhuis.info> wrote:
> >
> > Hi, this is your Linux kernel regression tracker.
> >
> > On 21.03.22 19:44, José Expósito wrote:
> > > This reverts commit 37ef4c19b4c659926ce65a7ac709ceaefb211c40.
> > >
> > > The touchpad present in the Dell Precision 7550 and 7750 laptops
> > > reports a HID_DG_BUTTONTYPE of type MT_BUTTONTYPE_CLICKPAD. However,
> > > the device is not a clickpad, it is a touchpad with physical buttons.
> > >
> > > In order to fix this issue, a quirk for the device was introduced in
> > > libinput [1] [2] to disable the INPUT_PROP_BUTTONPAD property:
> > >
> > > [Precision 7x50 Touchpad]
> > > MatchBus=i2c
> > > MatchUdevType=touchpad
> > > MatchDMIModalias=dmi:*svnDellInc.:pnPrecision7?50*
> > > AttrInputPropDisable=INPUT_PROP_BUTTONPAD
> > >
> > > However, because of the change introduced in 37ef4c19b4 ("Input: clear
> > > BTN_RIGHT/MIDDLE on buttonpads") the BTN_RIGHT key bit is not mapped
> > > anymore breaking the device right click button and making impossible to
> > > workaround it in user space.
> > >
> > > In order to avoid breakage on other present or future devices, revert
> > > the patch causing the issue.
> > >
> > > Cc: stable@vger.kernel.org
> > > Link: https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/481 [1]
> > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1868789 [2]
> > > Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> > > [...]
> >
> > Jiri, Benjamin, what the status here? Sure, this is not a crucial
> > regression and we are in the middle of the merge window, but it looks
> > like nothing has happened for a week now. Or was progress made somewhere
> > and I just missed it?
>
> No, I think it just wasn't picked up by the input maintainer yet
> (Dmitry, now in CC).
>
> FWIW:
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> José, please do not forget to add the input maintainer when you target
> the input tree, not the HID one :)
I see that there were several ACKs, but how many devices misuse the
HID_DG_BUTTONTYPE? Would it be better to quirk against either affected
Dell models, or particular touchpads (by HID IDs) instead of reverting
wholesale?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-03-31 4:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 18:44 [PATCH] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads" José Expósito
2022-03-22 11:15 ` Hans de Goede
2022-03-23 5:05 ` Peter Hutterer
2022-03-30 12:27 ` Thorsten Leemhuis
2022-03-30 12:30 ` Benjamin Tissoires
2022-03-31 4:13 ` Dmitry Torokhov [this message]
2022-03-31 4:38 ` Peter Hutterer
2022-04-01 4:23 ` Dmitry Torokhov
2022-04-05 9:35 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkUqajiNZmi+lAPC@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).