From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A674C433F5 for ; Tue, 4 Oct 2022 13:41:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229445AbiJDNln (ORCPT ); Tue, 4 Oct 2022 09:41:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbiJDNlZ (ORCPT ); Tue, 4 Oct 2022 09:41:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D250D390 for ; Tue, 4 Oct 2022 06:40:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 57E886146B for ; Tue, 4 Oct 2022 13:40:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 648E8C433C1; Tue, 4 Oct 2022 13:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664890858; bh=qGvXm+Rs80ISpZq8uWXihl1UTj7BuHmipmmYH4ZqWGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K3IL5axqUMvZUuHmya+iaiY5TxeG6XXNNe+/0PPIvbJrIuhxFaqgHbD7DFhvy1IXd 2DZyM+urb9eJbnmH2JLBX/kvwv2Ev/dEnAAwbAP8gxNdg9Oq0DKF/xqWNcCoRsCp9M UbsHW5cO7RQt8rZWDXG35n/U5jnHxtAkWm0PfQK8= Date: Tue, 4 Oct 2022 15:40:55 +0200 From: Greg Kroah-Hartman To: David Matthew Mattli Cc: Thorsten Leemhuis , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , stable@vger.kernel.org, regressions@lists.linux.dev, Slade Watkins , Jerry Ling , intel-gfx@lists.freedesktop.org Subject: Re: Regression on 5.19.12, display flickering on Framework laptop Message-ID: References: <55905860-adf9-312c-69cc-491ac8ce1a8b@cern.ch> <03147889-B21C-449B-B110-7E504C8B0EF4@sladewatkins.net> <714903fa-16c8-4247-d69d-74af6ef50bfa@leemhuis.info> <9aae6b15-265a-4ef9-87c1-83dfe5094378@smtp-relay.sendinblue.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9aae6b15-265a-4ef9-87c1-83dfe5094378@smtp-relay.sendinblue.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Oct 04, 2022 at 06:46:10AM -0500, David Matthew Mattli wrote: > Thorsten Leemhuis writes: > > > On 03.10.22 19:48, Ville Syrjälä wrote: > >> On Mon, Oct 03, 2022 at 08:45:18PM +0300, Ville Syrjälä wrote: > >>> On Sat, Oct 01, 2022 at 12:07:39PM +0200, Thorsten Leemhuis wrote: > >>>> On 30.09.22 14:26, Jerry Ling wrote: > >>>>> > >>>>> looks like someone has done it: > >>>>> https://bbs.archlinux.org/viewtopic.php?pid=2059823#p2059823 > >>>>> > >>>>> and the bisect points to: > >>>>> > >>>>> |# first bad commit: [fc6aff984b1c63d6b9e54f5eff9cc5ac5840bc8c] > >>>>> drm/i915/bios: Split VBT data into per-panel vs. global parts Best, Jerry > | > >>>> > >>>> FWIW, that's 3cf050762534 in mainline. Adding Ville, its author to the > >>>> list of recipients. > >>> > >>> I definitely had no plans to backport any of that stuff, > >>> but I guess the automagics did it anyway. > >>> > >>> Looks like stable is at least missing this pile of stuff: > >>> 50759c13735d drm/i915/pps: Keep VDD enabled during eDP probe > >>> 67090801489d drm/i915/pps: Reinit PPS delays after VBT has been fully > parsed > >>> 8e75e8f573e1 drm/i915/pps: Split PPS init+sanitize in two > >>> 586294c3c186 drm/i915/pps: Stash away original BIOS programmed PPS delays > >>> 89fcdf430599 drm/i915/pps: Don't apply quirks/etc. to the VBT PPS > >>> delays if they haven't been initialized > >>> 60b02a09598f drm/i915/pps: Introduce pps_delays_valid() > >>> > >>> But dunno if even that is enough. > > > > If you need testers: David (now CCed) apparently has a affected machine > > and offered to test patches in a different subthread of this thread. > > > > I cherry-picked the six commits Thorsten listed onto 5.19.12 and it > resolved the issue on my Framework laptop. Thanks for testing, but I'm just going to revert the offending commits as they probably shouldn't all be added to 5.19.y thanks, greg k-h