stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: David Matthew Mattli <dmm@mattli.us>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	stable@vger.kernel.org, regressions@lists.linux.dev,
	Slade Watkins <srw@sladewatkins.net>, Jerry Ling <jiling@cern.ch>,
	intel-gfx@lists.freedesktop.org
Subject: Re: Regression on 5.19.12, display flickering on Framework laptop
Date: Tue, 4 Oct 2022 16:44:35 +0300	[thread overview]
Message-ID: <Yzw4w6JQ2fKo9AE1@intel.com> (raw)
In-Reply-To: <Yzw3591mUb8b9Wst@kroah.com>

On Tue, Oct 04, 2022 at 03:40:55PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 04, 2022 at 06:46:10AM -0500, David Matthew Mattli wrote:
> > Thorsten Leemhuis writes:
> > 
> > > On 03.10.22 19:48, Ville Syrjälä wrote:
> > >> On Mon, Oct 03, 2022 at 08:45:18PM +0300, Ville Syrjälä wrote:
> > >>> On Sat, Oct 01, 2022 at 12:07:39PM +0200, Thorsten Leemhuis wrote:
> > >>>> On 30.09.22 14:26, Jerry Ling wrote:
> > >>>>>
> > >>>>> looks like someone has done it:
> > >>>>> https://bbs.archlinux.org/viewtopic.php?pid=2059823#p2059823
> > >>>>>
> > >>>>> and the bisect points to:
> > >>>>>
> > >>>>> |# first bad commit: [fc6aff984b1c63d6b9e54f5eff9cc5ac5840bc8c]
> > >>>>> drm/i915/bios: Split VBT data into per-panel vs. global parts Best, Jerry
> > |
> > >>>>
> > >>>> FWIW, that's 3cf050762534 in mainline. Adding Ville, its author to the
> > >>>> list of recipients.
> > >>>
> > >>> I definitely had no plans to backport any of that stuff,
> > >>> but I guess the automagics did it anyway.
> > >>>
> > >>> Looks like stable is at least missing this pile of stuff:
> > >>> 50759c13735d drm/i915/pps: Keep VDD enabled during eDP probe
> > >>> 67090801489d drm/i915/pps: Reinit PPS delays after VBT has been fully
> > parsed
> > >>> 8e75e8f573e1 drm/i915/pps: Split PPS init+sanitize in two
> > >>> 586294c3c186 drm/i915/pps: Stash away original BIOS programmed PPS delays
> > >>> 89fcdf430599 drm/i915/pps: Don't apply quirks/etc. to the VBT PPS
> > >>> delays if they haven't been initialized
> > >>> 60b02a09598f drm/i915/pps: Introduce pps_delays_valid()
> > >>>
> > >>> But dunno if even that is enough.
> > >
> > > If you need testers: David (now CCed) apparently has a affected machine
> > > and offered to test patches in a different subthread of this thread.
> > >
> > 
> > I cherry-picked the six commits Thorsten listed onto 5.19.12 and it
> > resolved the issue on my Framework laptop.
> 
> Thanks for testing, but I'm just going to revert the offending commits
> as they probably shouldn't all be added to 5.19.y

Yeah, revert seems the safer route. Thanks.

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2022-10-04 13:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30  2:26 Regression on 5.19.12, display flickering on Framework laptop Jerry Ling
2022-09-30  4:37 ` Greg KH
2022-09-30  5:59   ` Greg KH
2022-09-30 11:11     ` Slade Watkins
2022-09-30 11:22       ` Greg Kroah-Hartman
2022-09-30 11:56         ` Slade Watkins
2022-09-30 12:26       ` Jerry Ling
2022-09-30 12:49         ` Slade Watkins
2022-10-01 10:07         ` Thorsten Leemhuis
2022-10-01 12:34           ` Hans de Goede
2022-10-03 17:45           ` Ville Syrjälä
2022-10-03 17:48             ` Ville Syrjälä
2022-10-03 18:28               ` Thorsten Leemhuis
2022-10-04 12:35                 ` Ville Syrjälä
2022-10-04 12:57                   ` Greg Kroah-Hartman
     [not found]                 ` <9aae6b15-265a-4ef9-87c1-83dfe5094378@smtp-relay.sendinblue.com>
2022-10-04 13:40                   ` Greg Kroah-Hartman
2022-10-04 13:44                     ` Ville Syrjälä [this message]
2022-10-04 14:28                       ` Greg Kroah-Hartman
2022-09-30  5:10 ` Thorsten Leemhuis
2022-09-30 13:05   ` Jerry Ling
2022-09-30 15:02     ` Greg KH
2022-10-03 16:42       ` David Matthew Mattli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yzw4w6JQ2fKo9AE1@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dmm@mattli.us \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jiling@cern.ch \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=srw@sladewatkins.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).