From: Luis Chamberlain <mcgrof@kernel.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>,
Petr Mladek <pmladek@suse.com>, Petr Pavlu <petr.pavlu@suse.com>,
Prarit Bhargava <prarit@redhat.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
Borislav Petkov <bp@alien8.de>, NeilBrown <neilb@suse.de>,
Goldwyn Rodrigues <rgoldwyn@suse.com>,
david@redhat.com, mwilck@suse.com, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Lucas De Marchi <lucas.de.marchi@gmail.com>,
Ben Hutchings <benh@debian.org>,
Adam Manzanares <a.manzanares@samsung.com>
Subject: Re: [PATCH v2] module: Don't wait for GOING modules
Date: Fri, 24 Mar 2023 11:47:14 -0700 [thread overview]
Message-ID: <ZB3wMuynKnQ1IFjb@bombadil.infradead.org> (raw)
In-Reply-To: <20230324060321.c2szz34n6zggvubj@ldmartin-desk2.lan>
On Thu, Mar 23, 2023 at 11:03:21PM -0700, Lucas De Marchi wrote:
> On Thu, Mar 23, 2023 at 08:08:49AM -0700, Luis Chamberlain wrote:
> > On Thu, Mar 23, 2023 at 8:02 AM Lucas De Marchi
> > <lucas.demarchi@intel.com> wrote:
> > >
> > > On Wed, Mar 22, 2023 at 03:31:59PM -0700, Luis Chamberlain wrote:
> > > >On Sat, Mar 11, 2023 at 10:25:05PM -0800, Lucas De Marchi wrote:
> > > >> On Sat, Jan 21, 2023 at 02:40:20PM -0800, Luis Chamberlain wrote:
> > > >> > On Thu, Jan 19, 2023 at 04:58:53PM -0800, Luis Chamberlain wrote:
> > > >> > > On Thu, Jan 19, 2023 at 04:51:27PM -0800, Luis Chamberlain wrote:
> > > >> > > > On Thu, Jan 19, 2023 at 04:47:05PM +0100, Petr Mladek wrote:
> > > >> > > > > Yes, the -EINVAL error is strange. It is returned also in
> > > >> > > > > kernel/module/main.c on few locations. But neither of them
> > > >> > > > > looks like a good candidate.
> > > >> > > >
> > > >> > > > OK I updated to next-20230119 and I don't see the issue now.
> > > >> > > > Odd. It could have been an issue with next-20221207 which I was
> > > >> > > > on before.
> > > >> > > >
> > > >> > > > I'll run some more test and if nothing fails I'll send the fix
> > > >> > > > to Linux for rc5.
> > > >> > >
> > > >> > > Jeesh it just occured to me the difference, which I'll have to
> > > >> > > test next, for next-20221207 I had enabled module compression
> > > >> > > on kdevops with zstd.
> > > >> > >
> > > >> > > You can see the issues on kdevops git log with that... and I finally
> > > >> > > disabled it and the kmod test issue is gone. So it could be that
> > > >> > > but I just am ending my day so will check tomorrow if that was it.
> > > >> > > But if someone else beats me then great.
> > > >> > >
> > > >> > > With kdevops it should be a matter of just enabling zstd as I
> > > >> > > just bumped support for next-20230119 and that has module decompression
> > > >> > > disabled.
> > > >> >
> > > >> > So indeed, my suspcions were correct. There is one bug with
> > > >> > compression on debian:
> > > >> >
> > > >> > - gzip compressed modules don't end up in the initramfs
> > > >> >
> > > >> > There is a generic upstream kmod bug:
> > > >> >
> > > >> > - modprobe --show-depends won't grok compressed modules so initramfs
> > > >> > tools that use this as Debian likely are not getting module dependencies
> > > >> > installed in their initramfs
> > > >>
> > > >> are you sure you have the relevant compression setting enabled
> > > >> in kmod?
> > > >>
> > > >> $ kmod --version
> > > >> kmod version 30
> > > >> +ZSTD +XZ +ZLIB +LIBCRYPTO -EXPERIMENTAL
> > > >
> > > >Debian has:
> > > >
> > > >kmod version 30
> > > >+ZSTD +XZ -ZLIB +LIBCRYPTO -EXPERIMENTAL
> > >
> > > ^ so... mind the minus :). It doesn't support zlib.
> > >
> > > Change your kernel config to either compress the modules as xz or zstd.
> >
> > Oh so then we should complain about these things if an initramfs is
> > detected with modules compressed using a compression algorithm which
> > modprobe installed does not support. What tool would do that?
>
> I guess we could add that in depmod side as a dummy handler for when
> that config is off. Thoughts?
That sounds like a good solution, better than and complain before
allowing someone to boot and *not* be able to.
Luis
next prev parent reply other threads:[~2023-03-24 18:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 10:35 [PATCH v2] module: Don't wait for GOING modules Petr Pavlu
2022-12-05 19:54 ` Petr Mladek
2022-12-06 16:57 ` Petr Pavlu
2022-12-07 15:15 ` Petr Mladek
2022-12-08 2:44 ` Luis Chamberlain
2022-12-12 11:29 ` Petr Pavlu
2022-12-13 2:58 ` Luis Chamberlain
2022-12-13 5:09 ` Luis Chamberlain
2022-12-13 10:17 ` Petr Mladek
2022-12-13 13:36 ` Petr Pavlu
2023-01-18 0:04 ` Luis Chamberlain
2023-01-18 0:18 ` Luis Chamberlain
2023-01-18 15:12 ` Petr Pavlu
2023-01-18 18:42 ` Luis Chamberlain
2023-01-19 12:26 ` Petr Pavlu
2023-01-19 15:47 ` Petr Mladek
2023-01-20 0:51 ` Luis Chamberlain
2023-01-20 0:58 ` Luis Chamberlain
2023-01-21 22:40 ` Luis Chamberlain
2023-03-11 21:36 ` Luis Chamberlain
2023-03-12 6:25 ` Lucas De Marchi
2023-03-22 22:31 ` Luis Chamberlain
2023-03-23 15:01 ` Lucas De Marchi
2023-03-23 15:08 ` Luis Chamberlain
2023-03-24 6:03 ` Lucas De Marchi
2023-03-24 18:47 ` Luis Chamberlain [this message]
2023-01-24 19:58 ` Luis Chamberlain
2023-01-18 20:02 ` Borislav Petkov
2023-01-19 1:23 ` Luis Chamberlain
2023-01-19 23:37 ` Luis Chamberlain
2023-01-19 1:15 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB3wMuynKnQ1IFjb@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=a.manzanares@samsung.com \
--cc=benh@debian.org \
--cc=bp@alien8.de \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
--cc=mwilck@suse.com \
--cc=neilb@suse.de \
--cc=petr.pavlu@suse.com \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=rgoldwyn@suse.com \
--cc=stable@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
--cc=vincenzopalazzodev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).