From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Tudor.Ambarus@microchip.com, linux-mtd@lists.infradead.org
Cc: p.yadav@ti.com, michael@walle.cc, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: Check for zero erase size in spi_nor_find_best_erase_type()
Date: Mon, 20 Dec 2021 13:34:56 +0100 [thread overview]
Message-ID: <ac686ed2-2638-3e77-4a4d-b5b0387ff9ff@nokia.com> (raw)
In-Reply-To: <88db4d69-e983-a359-ad50-9981e465b1fa@microchip.com>
Hi!
On 20/12/2021 12:28, Tudor.Ambarus@microchip.com wrote:
>> I however run the above patch because of the reasons described in the commit message.
>> Nevertheless, the bug fixed now remains a bug no matter what triggers it.
> I'm not yet convinced that this is the best way to fix it. Should we update
> the erase mask to cover this case?
Well, let's wait until the maintainers form their opinion. I've listed the functions which
zero the size (spi_nor_parse_4bait() or spi_nor_init_non_uniform_erase_map()), there are
already functions which check for zero:
spi_nor_select_uniform_erase()
spi_nor_select_erase()
--
Best regards,
Alexander Sverdlin.
next prev parent reply other threads:[~2021-12-20 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 8:14 [PATCH v2] mtd: spi-nor: Check for zero erase size in spi_nor_find_best_erase_type() Alexander A Sverdlin
2021-12-18 1:31 ` Tudor.Ambarus
2021-12-20 9:46 ` Alexander Sverdlin
2021-12-20 11:28 ` Tudor.Ambarus
2021-12-20 12:34 ` Alexander Sverdlin [this message]
2022-11-21 13:41 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac686ed2-2638-3e77-4a4d-b5b0387ff9ff@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).