From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Paul Burton <paulburton@kernel.org>,
James Hogan <jhogan@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: build failure of mips decstation_r4k_defconfig with binutils-2_37
Date: Tue, 17 Aug 2021 15:47:10 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2108171536240.45958@angie.orcam.me.uk> (raw)
In-Reply-To: <YRuxrfYxahPbHmXl@linux-mips.org>
On Tue, 17 Aug 2021, Ralf Baechle wrote:
> > While I was testing v5.4.142-rc2 I noticed mips build of
> > decstation_r4k_defconfig fails with binutils-2_37. The error is:
> >
> > arch/mips/dec/prom/locore.S: Assembler messages:
> > arch/mips/dec/prom/locore.S:29: Error: opcode not supported on this
> > processor: r4600 (mips3) `rfe'
> >
> > I have also reported this at https://sourceware.org/bugzilla/show_bug.cgi?id=28241
>
> It would appear gas got more anal about ISA checking for the RFE instructions
> which did only exist in MIPS I and II; MIPS III and later use ERET for
> returning from an exception.
Yes, I made such a change when I discovered the mess around coprocessor
instructions in binutils earlier this year. Eighteen patches total to
straighten it out. Some instructions were misassembled even, and no
proper subsetting was made, so you could come with a nonsensical mixture
when disassembling. And RFE was disassembled as `c0 0x10' regardless of
the ISA chosen.
> It should be fixable by simply putting gas into mips1 mode. Can you test
> below patch?
But it's missing the point, as I noted in the other message. I've been
too busy with higher priority stuff to get to a proper fix right away (I
thought I was the last one using the DECstation, and especially with the
top of the tree binutils).
Maciej
next prev parent reply other threads:[~2021-08-17 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 11:54 build failure of mips decstation_r4k_defconfig with binutils-2_37 Sudip Mukherjee
2021-08-17 12:55 ` Ralf Baechle
2021-08-17 13:33 ` Sudip Mukherjee
2021-08-17 13:47 ` Maciej W. Rozycki [this message]
2021-08-17 13:36 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2108171536240.45958@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).