From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Philippe Mazenauer <philippe.mazenauer@outlook.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: Yangtao Li <tiny.windzz@gmail.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] clk: armada-xp: Remove unused variables
Date: Tue, 21 May 2019 21:31:59 +0000 [thread overview]
Message-ID: <b60737773b9049bb80f6b325ac543e67@svr-chch-ex1.atlnz.lc> (raw)
In-Reply-To: VI1PR07MB4432F4F275BC445289FF3D9CFD070@VI1PR07MB4432.eurprd07.prod.outlook.com
Hi Philippe,
On 21/05/19 8:58 PM, Philippe Mazenauer wrote:
> Variables 'mv98dx3236_gating_desc' and 'mv98dx3236_coreclks' are
> declared static and initialized, but are not used in the file.
>
> ../drivers/clk/mvebu/armada-xp.c:213:41: warning: ‘mv98dx3236_gating_desc’ defined but not used [-Wunused-const-variable=]
> static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
> ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/clk/mvebu/armada-xp.c:171:38: warning: ‘mv98dx3236_coreclks’ defined but not used [-Wunused-const-variable=]
> static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
The usage of these was moved to a separate file in a later commit and
the original code wasn't fully cleaned up.
Fixes: 337072604224 ("clk: mvebu: Expand mv98dx3236-core-clock support")
Cc: stable@vger.kernel.org
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Thanks
> ---
> drivers/clk/mvebu/armada-xp.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
> index fa1568279c23..2ae24a5debd0 100644
> --- a/drivers/clk/mvebu/armada-xp.c
> +++ b/drivers/clk/mvebu/armada-xp.c
> @@ -168,11 +168,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
> .num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
> };
>
> -static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> - .get_tclk_freq = mv98dx3236_get_tclk_freq,
> - .get_cpu_freq = mv98dx3236_get_cpu_freq,
> -};
> -
> /*
> * Clock Gating Control
> */
> @@ -210,15 +205,6 @@ static const struct clk_gating_soc_desc axp_gating_desc[] __initconst = {
> { }
> };
>
> -static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
> - { "ge1", NULL, 3, 0 },
> - { "ge0", NULL, 4, 0 },
> - { "pex00", NULL, 5, 0 },
> - { "sdio", NULL, 17, 0 },
> - { "xor0", NULL, 22, 0 },
> - { }
> -};
> -
> static void __init axp_clk_init(struct device_node *np)
> {
> struct device_node *cgnp =
>
parent reply other threads:[~2019-05-21 21:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <VI1PR07MB4432F4F275BC445289FF3D9CFD070@VI1PR07MB4432.eurprd07.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b60737773b9049bb80f6b325ac543e67@svr-chch-ex1.atlnz.lc \
--to=chris.packham@alliedtelesis.co.nz \
--cc=gregory.clement@bootlin.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=philippe.mazenauer@outlook.de \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).