From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>, peterz@infradead.org
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Zhang Qiao <zhangqiao22@huawei.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+af7a719bc92395ee41b3@syzkaller.appspotmail.com
Subject: Re: [PATCH v4] sched/fair: Fix fault in reweight_entity
Date: Thu, 3 Feb 2022 08:14:41 -0800 [thread overview]
Message-ID: <b95078f2-180a-e691-d10b-f19a87575274@linaro.org> (raw)
In-Reply-To: <dc241a1f-74c2-3db6-e932-04b653e469bb@arm.com>
On 2/3/22 01:40, Dietmar Eggemann wrote:
>> -static void set_load_weight(struct task_struct *p, bool update_load)
>> +static void set_load_weight(struct task_struct *p)
>> {
>> int prio = p->static_prio - MAX_RT_PRIO;
>> struct load_weight *load = &p->se.load;
>> + bool update_load = !(READ_ONCE(p->__state) & TASK_NEW);
> nit-pick: reverse fir tree order
>
> cat Documentation/process/maintainer-tip.rst | grep -A 10 "Variable
> declarations"
>
> I was able to recreate the initial issue with the reproducer on arm64
> Juno-r0 with CONFIG_CGROUP_SCHED=y .
>
> Reviewed-by: Dietmar Eggemann<dietmar.eggemann@arm.com>
Thanks for reviewing. I will send a v5 soon.
--
Thanks,
Tadeusz
prev parent reply other threads:[~2022-02-03 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 19:34 [PATCH v3] sched/fair: Fix fault in reweight_entity Tadeusz Struk
2022-01-26 13:53 ` Dietmar Eggemann
2022-01-26 23:50 ` Tadeusz Struk
2022-01-27 20:56 ` [PATCH v4] " Tadeusz Struk
2022-02-03 9:40 ` Dietmar Eggemann
2022-02-03 16:14 ` Tadeusz Struk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b95078f2-180a-e691-d10b-f19a87575274@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+af7a719bc92395ee41b3@syzkaller.appspotmail.com \
--cc=vincent.guittot@linaro.org \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).