From: Stefan Agner <stefan@agner.ch>
To: Greg KH <greg@kroah.com>
Cc: Anders Roxell <anders.roxell@linaro.org>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
davem@davemloft.net, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, clang-built-linux@googlegroups.com,
ulli.kroll@googlemail.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org, amitkarwar@gmail.com,
nishants@marvell.com, gbhat@marvell.com, huxinming820@gmail.com,
kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
rostedt@goodmis.org, mingo@redhat.com, dmitry.torokhov@gmail.com,
ndesaulniers@google.com, nathan@kernel.org,
linux-input@vger.kernel.org,
Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH 4.19 5/6] ARM: 8788/1: ftrace: remove old mcount support
Date: Tue, 11 Jan 2022 21:58:42 +0100 [thread overview]
Message-ID: <cf6f7b9e8694fa87c3e27bd6be67afd2@agner.ch> (raw)
In-Reply-To: <YcBhqJMLdwieZa8X@kroah.com>
On 2021-12-20 11:57, Greg KH wrote:
> On Fri, Dec 17, 2021 at 03:41:18PM +0100, Anders Roxell wrote:
>> From: Stefan Agner <stefan@agner.ch>
>>
>> commit d3c61619568c88d48eccd5e74b4f84faa1440652 upstream.
>>
>> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
>> raised the minimum GCC version to 4.6. Old mcount is only required for
>> GCC versions older than 4.4.0. Hence old mcount support can be dropped
>> too.
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Why is this needed for clang builds in 4.19?
As far as I remember, Clang tripped over this part:
-#ifndef CONFIG_OLD_MCOUNT
-#if (__GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 4))
-#error Ftrace requires CONFIG_FRAME_POINTER=y with GCC older than
4.4.0.
-#endif
-#endif
Since mcount support wasn't required upstream at that point, instead of
fixing it for Clang I just removed it.
--
Stefan
next prev parent reply other threads:[~2022-01-11 21:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 14:41 [PATCH 4.19 0/6] fix warning and errors on arm built with clang Anders Roxell
2021-12-17 14:41 ` [PATCH 4.19 1/6] net: lan78xx: Avoid unnecessary self assignment Anders Roxell
2021-12-17 14:41 ` [PATCH 4.19 2/6] ARM: 8805/2: remove unneeded naked function usage Anders Roxell
2021-12-17 14:41 ` [PATCH 4.19 3/6] mwifiex: Remove unnecessary braces from HostCmd_SET_SEQ_NO_BSS_INFO Anders Roxell
2021-12-20 10:56 ` Greg KH
2021-12-20 12:13 ` Joe Perches
2021-12-20 14:00 ` David Laight
2021-12-17 14:41 ` [PATCH 4.19 4/6] ARM: 8800/1: use choice for kernel unwinders Anders Roxell
2021-12-17 14:41 ` [PATCH 4.19 5/6] ARM: 8788/1: ftrace: remove old mcount support Anders Roxell
2021-12-20 10:57 ` Greg KH
2022-01-11 20:58 ` Stefan Agner [this message]
2022-01-11 21:04 ` Nick Desaulniers
2021-12-17 14:41 ` [PATCH 4.19 6/6] Input: touchscreen - avoid bitwise vs logical OR warning Anders Roxell
2021-12-20 10:59 ` Greg KH
2021-12-21 12:24 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf6f7b9e8694fa87c3e27bd6be67afd2@agner.ch \
--to=stefan@agner.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=amitkarwar@gmail.com \
--cc=anders.roxell@linaro.org \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=gbhat@marvell.com \
--cc=greg@kroah.com \
--cc=huxinming820@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).