From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465C3C433F5 for ; Thu, 17 Mar 2022 16:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230004AbiCQQ3b (ORCPT ); Thu, 17 Mar 2022 12:29:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbiCQQ3a (ORCPT ); Thu, 17 Mar 2022 12:29:30 -0400 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77385F61F5; Thu, 17 Mar 2022 09:28:12 -0700 (PDT) Received: from [192.168.0.3] (ip5f5aef3c.dynamic.kabel-deutschland.de [95.90.239.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 7E29261EA1923; Thu, 17 Mar 2022 17:28:09 +0100 (CET) Message-ID: Date: Thu, 17 Mar 2022 17:28:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [EXT] Re: [PATCH net] bnx2x: fix built-in kernel driver load failure Content-Language: en-US To: Jakub Kicinski Cc: Manish Chopra , netdev@vger.kernel.org, Ariel Elior , regressions@lists.linux.dev, stable@vger.kernel.org, it+netdev@molgen.mpg.de References: <20220316214613.6884-1-manishc@marvell.com> <35d305f5-aa84-2c47-7efd-66fffb91c398@molgen.mpg.de> <1986e70f-9e3b-cc64-4c15-dbc2abd1dc8d@molgen.mpg.de> <20220317083314.54f360b3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Paul Menzel In-Reply-To: <20220317083314.54f360b3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Dear Jakub, Am 17.03.22 um 16:33 schrieb Jakub Kicinski: > On Thu, 17 Mar 2022 14:31:45 +0100 Paul Menzel wrote: >>>> I think it’s important to document, that the firmware was not present in the >>>> initrd. >>> >>> I believe this problem has nothing to do with initrd module/FW but >>> rather a module built in the kernel/vmlinuz (CONFIG_BNX2X=y) itself, >>> A module load from initrd works fine and can access the initrd FW >>> files present in initrd file system even during the probe. For >>> example, when I had CONFIG_BNX2X=m, it loads the module fine from >>> initrd with FW files present in initrd file system. When I had >>> CONFIG_BNX2X=y, which I believe doesn't install/load module in/from >>> initrd but in kernel (vmlinuz) itself, that's where it can't access >>> the firmware file and cause the load failure. >> >> I can only say, that adding the firmware to the initrd worked around the >> problem on our side with `CONFIG_BNX2X=y`. > > I'd like to ship this one to Linus today. It sounds like it's > okay from functional perspective, can I improve the commit message as > you were suggesting and leave the comment / print improvements to a > later patch? Sure, fine by me. Kind regards, Paul