From: Johannes Berg <johannes@sipsolutions.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v4.19 1/2] mac80211: mark TX-during-stop for TX in in_reconfig
Date: Sat, 18 Dec 2021 09:56:00 +0100 [thread overview]
Message-ID: <d224b7c664182221bc2209ce5107ff3fd65be9d3.camel@sipsolutions.net> (raw)
In-Reply-To: <Yb0e8mSZZT0jxgSl@kroah.com>
On Sat, 2021-12-18 at 00:36 +0100, Greg KH wrote:
>
> Yeah, I don't think it's needed, but as it was marked to go back really
> far, I wanted to give you the option to do so or not.
>
Yeah I marked it because I'm pretty sure that problem _was_ introduced
that far back with the TXQ code, but OTOH I'm not even sure initially it
had users there, and then users that would run into the restart issue
... probably not, otherwise I'd think we'd have heard about it earlier?
Backporting the IEEE80211_TXQ_STOP_NETIF_TX stuff doesn't seem that
problematic either, but I'm not convinced it's worth it, and I suppose
somebody whose driver actually uses it on those kernels would better
take a look - I'm not familiar with all the drivers in detail, and
iwlwifi doesn't use it yet there.
johannes
prev parent reply other threads:[~2021-12-18 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 20:35 [PATCH v4.19 1/2] mac80211: mark TX-during-stop for TX in in_reconfig Johannes Berg
2021-12-17 20:35 ` [PATCH v4.19 2/2] mac80211: validate extended element ID is present Johannes Berg
2021-12-17 20:42 ` [PATCH v4.19 1/2] mac80211: mark TX-during-stop for TX in in_reconfig Johannes Berg
2021-12-17 23:36 ` Greg KH
2021-12-18 8:56 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d224b7c664182221bc2209ce5107ff3fd65be9d3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).