From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42E1C433DB for ; Thu, 4 Mar 2021 21:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D05964F47 for ; Thu, 4 Mar 2021 21:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235319AbhCDVIm (ORCPT ); Thu, 4 Mar 2021 16:08:42 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:51564 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234921AbhCDVId (ORCPT ); Thu, 4 Mar 2021 16:08:33 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Ds3NF6Zhxz1qs10; Thu, 4 Mar 2021 22:07:24 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Ds3ND3k9kz1qqkJ; Thu, 4 Mar 2021 22:07:24 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id NF9l6MSuqCwo; Thu, 4 Mar 2021 22:07:22 +0100 (CET) X-Auth-Info: /bjdHCSRRBO1hy/kHQ3KWZ31WRCi0CyJyL23VTq/CMI= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 4 Mar 2021 22:07:22 +0100 (CET) Subject: Re: [PATCH AUTOSEL 5.10 050/217] rsi: Fix TX EAPOL packet handling against iwlwifi AP To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Angus Ainslie , "David S . Miller" , Jakub Kicinski , Kalle Valo , Lee Jones , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , linux-wireless@vger.kernel.org, netdev@vger.kernel.org References: <20201223021626.2790791-1-sashal@kernel.org> <20201223021626.2790791-50-sashal@kernel.org> <68699f8a-2fcd-3b3d-f809-afa54790e9f9@denx.de> From: Marek Vasut Message-ID: Date: Thu, 4 Mar 2021 22:07:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 3/4/21 9:47 PM, Sasha Levin wrote: > On Tue, Mar 02, 2021 at 08:25:49PM +0100, Marek Vasut wrote: >> On 12/23/20 3:13 AM, Sasha Levin wrote: >> >> Hello Sasha, >> >>> From: Marek Vasut >>> >>> [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] >>> >>> In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in >>> AP mode, >>> the association fails. The former is using wpa_supplicant during >>> association, >>> the later is set up using hostapd: >> >> [...] >> >> Was this patch possibly missed from 5.10.y ? > > I'm not sure what happened there, but I can queue it up. Thank you >> Also, while at it, I think it might make sense to pick the following >> two patches as well, they dramatically reduce interrupt rate of the >> RSI WiFi device, so it stops overloading lower-end devices: >> 287431463e786 ("rsi: Move card interrupt handling to RX thread") > > And this one too. Thanks >> abd131a19f6b8 ("rsi: Clean up loop in the interrupt handler") > > But not this one, it looks like just a cleanup. Why is it needed? Now I got confused, yes, please skip abd131a19f6b8, thanks for spotting it. (I still have one more patch for the RSI wifi which I need to send out, but that's for later)