From: Jocelyn Falempe <jfalempe@redhat.com>
To: dri-devel@lists.freedesktop.org, kuohsiang_chou@aspeedtech.com,
David Airlie <airlied@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: regressions@lists.linux.dev, stable@vger.kernel.org
Subject: [REGRESSION] VGA output with AST 2600 graphics.
Date: Wed, 1 Jun 2022 11:33:16 +0200 [thread overview]
Message-ID: <d84ba981-d907-f942-6b05-67c836580542@redhat.com> (raw)
Hi,
I've found a regression in the ast driver, for AST2600 hardware.
before the upstream commit f9bd00e0ea9d
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=f9bd00e0ea9d9b04140aa969a9a13ad3597a1e4e
The ast driver handled AST 2600 chip like an AST 2500.
After this commit, it uses some default values, more like the older AST
chip.
There are a lot of places in the driver like this:
https://elixir.bootlin.com/linux/v5.18.1/source/drivers/gpu/drm/ast/ast_post.c#L82
where it checks for (AST2300 || AST2400 || AST2500) but not for AST2600.
This makes the VGA output, to be blurred and flickered with whites lines
on AST2600.
The issue is present since v5.11
For v5.11~v5.17 I propose a simple workaround (as there are no other
reference to AST2600 in the driver):
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -146,7 +146,8 @@ static int ast_detect_chip(struct drm_device *dev,
bool *need_post)
/* Identify chipset */
if (pdev->revision >= 0x50) {
- ast->chip = AST2600;
+ /* Workaround to use the same codepath for AST2600 */
+ ast->chip = AST2500;
drm_info(dev, "AST 2600 detected\n");
} else if (pdev->revision >= 0x40) {
ast->chip = AST2500;
starting from v5.18, there is another reference to AST2600 in the code
https://elixir.bootlin.com/linux/v5.18/source/drivers/gpu/drm/ast/ast_main.c#L212
So I think someone with good aspeed knowledge should review all
locations where there is a test for AST2500, and figure out what should
be done for AST2600
Thanks,
--
Jocelyn
next reply other threads:[~2022-06-01 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 9:33 Jocelyn Falempe [this message]
2022-06-01 10:33 ` [REGRESSION] VGA output with AST 2600 graphics Thomas Zimmermann
2022-06-01 12:29 ` Jocelyn Falempe
2022-06-07 11:02 ` Thorsten Leemhuis
2022-06-07 12:05 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d84ba981-d907-f942-6b05-67c836580542@redhat.com \
--to=jfalempe@redhat.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kuohsiang_chou@aspeedtech.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).