From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Fabien Parent <fparent@baylibre.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: Miles Chen <miles.chen@mediatek.com>,
Bear Wang <bear.wang@mediatek.com>,
Pablo Sun <pablo.sun@mediatek.com>,
Macpaul Lin <macpaul@gmail.com>, <linux-usb@vger.kernel.org>,
<stable@vger.kernel.org>, Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v2] arm64: dts: mediatek: mt8195-demo: fix the memory size of node secmon
Date: Mon, 24 Oct 2022 14:18:05 +0800 [thread overview]
Message-ID: <da9f8b90-e4d1-5893-f656-1bb0221ea7f7@mediatek.com> (raw)
In-Reply-To: <20220929084714.15143-1-macpaul.lin@mediatek.com>
On 9/29/22 16:47, Macpaul Lin wrote:
> The size of device tree node secmon (bl31_secmon_reserved) was
> incorrect. It should be increased to 2MiB (0x200000).
>
> The origin setting will cause some abnormal behavior due to
> trusted-firmware-a and related firmware didn't load correctly.
> The incorrect behavior may vary because of different software stacks.
> For example, it will cause build error in some Yocto project because
> it will check if there was enough memory to load trusted-firmware-a
> to the reserved memory.
>
> When mt8195-demo.dts sent to the upstream, at that time the size of
> BL31 was small. Because supported functions and modules in BL31 are
> basic sets when the board was under early development stage.
>
> Now BL31 includes more firmwares of coprocessors and maturer functions
> so the size has grown bigger in real applications. According to the value
> reported by customers, we think reserved 2MiB for BL31 might be enough
> for maybe the following 2 or 3 years.
Dear Matthias, sorry for a gentle reminder. MediaTek hope this simple
fix could be applied to 6.1-rc and be picked-up to current stable tree
after v5.19. Thanks a lot.
> Cc: stable@vger.kernel.org # v5.19
> Fixes: 6147314aeedc ("arm64: dts: mediatek: Add device-tree for MT8195 Demo board")
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> ---
> Changes for v2
> - Add more information about the size difference for BL31 in commit message.
> Thanks for Miles's review.
>
> arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> index 4fbd99eb496a..dec85d254838 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> @@ -56,10 +56,10 @@
> #size-cells = <2>;
> ranges;
>
> - /* 192 KiB reserved for ARM Trusted Firmware (BL31) */
> + /* 2 MiB reserved for ARM Trusted Firmware (BL31) */
> bl31_secmon_reserved: secmon@54600000 {
> no-map;
> - reg = <0 0x54600000 0x0 0x30000>;
> + reg = <0 0x54600000 0x0 0x200000>;
> };
>
> /* 12 MiB reserved for OP-TEE (BL32)
Regards,
Macpaul Lin
prev parent reply other threads:[~2022-10-24 6:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 9:16 [PATCH] arm64: dts: mediatek: mt8195-demo: fix the memory size of node secmon Macpaul Lin
2022-09-26 7:05 ` Miles Chen
2022-09-27 4:00 ` Macpaul Lin
2022-09-28 1:47 ` [PATCH] arm64: dts: mediatek: mt8195-demo: fix the memory size of Miles Chen
2022-09-29 8:47 ` [PATCH v2] arm64: dts: mediatek: mt8195-demo: fix the memory size of node secmon Macpaul Lin
2022-10-24 6:18 ` Macpaul Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da9f8b90-e4d1-5893-f656-1bb0221ea7f7@mediatek.com \
--to=macpaul.lin@mediatek.com \
--cc=bear.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=miles.chen@mediatek.com \
--cc=pablo.sun@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).