From: Baolin Wang <baolin.wang@linaro.org>
To: stable@vger.kernel.org, sre@kernel.org
Cc: david@lechnology.com, linux-pm@vger.kernel.org, arnd@arndb.de,
baolin.wang@linaro.org, orsonzhai@gmail.com,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org
Subject: [BACKPORT 4.14.y v2 4/6] power: supply: sysfs: ratelimit property read error message
Date: Thu, 5 Sep 2019 11:08:27 +0800 [thread overview]
Message-ID: <f00b144ce6707ab64cdf1c61ece385e919630815.1567649729.git.baolin.wang@linaro.org> (raw)
In-Reply-To: <cover.1567649728.git.baolin.wang@linaro.org>
From: David Lechner <david@lechnology.com>
[Upstream commit 87a2b65fc855e6be50f791c2ebbb492541896827]
This adds rate limiting to the message that is printed when reading a
power supply property via sysfs returns an error. This will prevent
userspace applications from unintentionally dDOSing the system by
continuously reading a property that returns an error.
Signed-off-by: David Lechner <david@lechnology.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/power/supply/power_supply_sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index eb5dc74..2ccaf4f 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -91,7 +91,8 @@ static ssize_t power_supply_show_property(struct device *dev,
dev_dbg(dev, "driver has no data for `%s' property\n",
attr->attr.name);
else if (ret != -ENODEV && ret != -EAGAIN)
- dev_err(dev, "driver failed to report `%s' property: %zd\n",
+ dev_err_ratelimited(dev,
+ "driver failed to report `%s' property: %zd\n",
attr->attr.name, ret);
return ret;
}
--
1.7.9.5
next prev parent reply other threads:[~2019-09-05 3:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 3:05 [BACKPORT 4.14.y v2 0/6] Candidates from Spreadtrum 4.14 product kernel Baolin Wang
2019-09-05 3:06 ` [BACKPORT 4.14.y v2 1/6] ip6: fix skb leak in ip6frag_expire_frag_queue() Baolin Wang
2019-09-05 3:07 ` [BACKPORT 4.14.y v2 2/6] locking/lockdep: Add debug_locks check in __lock_downgrade() Baolin Wang
2019-09-10 14:32 ` Greg KH
2019-09-11 3:39 ` Baolin Wang
2019-09-05 3:07 ` [BACKPORT 4.14.y v2 3/6] pinctrl: sprd: Use define directive for sprd_pinconf_params values Baolin Wang
2019-09-05 3:08 ` Baolin Wang [this message]
2019-09-05 3:10 ` [BACKPORT 4.14.y v2 5/6] ppp: mppe: Revert "ppp: mppe: Add softdep to arc4" Baolin Wang
2019-09-05 16:16 ` Eric Biggers
2019-09-06 6:13 ` Baolin Wang
2019-09-05 3:11 ` [BACKPORT 4.14.y v2 6/6] serial: sprd: Modify the baud rate calculation formula Baolin Wang
2019-09-05 9:01 ` Johan Hovold
2019-09-05 9:58 ` Baolin Wang
2019-09-20 8:06 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f00b144ce6707ab64cdf1c61ece385e919630815.1567649729.git.baolin.wang@linaro.org \
--to=baolin.wang@linaro.org \
--cc=arnd@arndb.de \
--cc=david@lechnology.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=sre@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).