From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
x86@kernel.org
Cc: sstabellini@kernel.org, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hans@knorrie.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] xen: Fix x86 sched_clock() interface for xen
Date: Fri, 11 Jan 2019 15:35:54 -0500 [thread overview]
Message-ID: <f0b7963a-049f-e89e-a9cb-9e0f18f771a3@oracle.com> (raw)
In-Reply-To: <20190111120805.24852-1-jgross@suse.com>
On 1/11/19 7:08 AM, Juergen Gross wrote:
> @@ -421,6 +424,11 @@ void xen_restore_time_memory_area(void)
> if (ret != 0)
> pr_notice("Cannot restore secondary vcpu_time_info (err %d)",
> ret);
> +
> +out:
> + /* Need pvclock_resume() before using xen_clocksource_read(). */
> + pvclock_resume();
Do we want to drop it from xen_timer_resume then?
BTW, I ran this code a few times on top of for-linus-4.21 and didn't see
any of the problems that Hans described. I didn't do LM, only
save/restore, but I'd think it shouldn't make any difference.
-boris
next prev parent reply other threads:[~2019-01-11 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 12:08 [PATCH v2] xen: Fix x86 sched_clock() interface for xen Juergen Gross
2019-01-11 13:12 ` Hans van Kranenburg
2019-01-11 14:01 ` [Xen-devel] " Juergen Gross
2019-01-11 15:57 ` Hans van Kranenburg
2019-01-11 21:46 ` Hans van Kranenburg
2019-01-11 20:35 ` Boris Ostrovsky [this message]
2019-01-14 12:43 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b7963a-049f-e89e-a9cb-9e0f18f771a3@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hans@knorrie.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).