From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E7DC4361B for ; Tue, 15 Dec 2020 08:05:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8288B2228A for ; Tue, 15 Dec 2020 08:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbgLOIE5 (ORCPT ); Tue, 15 Dec 2020 03:04:57 -0500 Received: from mga17.intel.com ([192.55.52.151]:59479 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbgLOIEr (ORCPT ); Tue, 15 Dec 2020 03:04:47 -0500 IronPort-SDR: iMSO8qop0vBUw73olcszh6hOc18CAY01VComXn0smvo87d8Ug3m1OvhAKLIXDByslBpwcQYLJz a7hLZRnZ8gEA== X-IronPort-AV: E=McAfee;i="6000,8403,9835"; a="154649322" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="154649322" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 00:04:05 -0800 IronPort-SDR: X7w60umHBYVcg81LO00WjKgRfF1of3r81LUUCqpVwXv7b2knWPLG8UHmjWQoo5S6v5+8SEv6ng j9cPVQfU3mQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="558613651" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.94]) ([10.237.72.94]) by fmsmga005.fm.intel.com with ESMTP; 15 Dec 2020 00:04:02 -0800 Subject: Re: [PATCH] mmc: sdhci-xenon: fix 1.8v regulator stabilization To: Marcin Wojtas , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Cc: ulf.hansson@linaro.org, huziji@marvell.com, jaz@semihalf.com, tn@semihalf.com, kostap@marvell.com, Alex Leibovich , stable@vger.kernel.org References: <20201211141656.24915-1-mw@semihalf.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Tue, 15 Dec 2020 10:03:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201211141656.24915-1-mw@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 11/12/20 4:16 pm, Marcin Wojtas wrote: > From: Alex Leibovich > > Automatic Clock Gating is a feature used for the power > consumption optimisation. It turned out that > during early init phase it may prevent the stable voltage > switch to 1.8V - due to that on some platfroms an endless platfroms -> platforms > printout in dmesg can be observed: > "mmc1: 1.8V regulator output did not became stable" > Fix the problem by disabling the ACG at very beginning > of the sdhci_init and let that be enabled later. > > Fixes: 3a3748dba881 ("mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality") > Signed-off-by: Alex Leibovich > Signed-off-by: Marcin Wojtas > Cc: stable@vger.kernel.org Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-xenon.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c > index c67611fdaa8a..4b05f6fdefb4 100644 > --- a/drivers/mmc/host/sdhci-xenon.c > +++ b/drivers/mmc/host/sdhci-xenon.c > @@ -168,7 +168,12 @@ static void xenon_reset_exit(struct sdhci_host *host, > /* Disable tuning request and auto-retuning again */ > xenon_retune_setup(host); > > - xenon_set_acg(host, true); > + /* > + * The ACG should be turned off at the early init time, in order > + * to solve a possile issues with the 1.8V regulator stabilization. a possile -> possible > + * The feature is enabled in later stage. > + */ > + xenon_set_acg(host, false); > > xenon_set_sdclk_off_idle(host, sdhc_id, false); > >