From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE65C2F3A0 for ; Mon, 21 Jan 2019 13:07:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1ED5F2084C for ; Mon, 21 Jan 2019 13:07:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="Xruhvvlk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728798AbfAUNHY (ORCPT ); Mon, 21 Jan 2019 08:07:24 -0500 Received: from mail-eopbgr40049.outbound.protection.outlook.com ([40.107.4.49]:40192 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727449AbfAUNHY (ORCPT ); Mon, 21 Jan 2019 08:07:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LBMX7i5YZir/UD3A9+tD3Vypfb6l/B5oS2gTwrXqshk=; b=XruhvvlkspjlmZ4V0IX/0Xtdvtf8BpdI9/uFmqg5R88VknuQyg2wjVRXCjUOfX1EoesX6Kk+tSbZX8kX3+zU1K369grNw6sk9RFBisHn83w3FwxAagizZ60WhbE1dLEhk0oSCBjT+YSV3BGqMUFkoXgBAF5Wp1NxQQQ6yjisHRo= Received: from HE1PR05CA0295.eurprd05.prod.outlook.com (2603:10a6:7:93::26) by DBBPR05MB6427.eurprd05.prod.outlook.com (2603:10a6:10:c9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.29; Mon, 21 Jan 2019 13:07:20 +0000 Received: from DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::202) by HE1PR05CA0295.outlook.office365.com (2603:10a6:7:93::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.24 via Frontend Transport; Mon, 21 Jan 2019 13:07:20 +0000 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=pass action=none header.from=mellanox.com; Received-SPF: Pass (protection.outlook.com: domain of mellanox.com designates 193.47.165.134 as permitted sender) receiver=protection.outlook.com; client-ip=193.47.165.134; helo=mtlcas13.mtl.com; Received: from mtlcas13.mtl.com (193.47.165.134) by DB5EUR03FT053.mail.protection.outlook.com (10.152.21.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1382.18 via Frontend Transport; Mon, 21 Jan 2019 13:07:19 +0000 Received: from MTLCAS13.mtl.com (10.0.8.78) by mtlcas13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Mon, 21 Jan 2019 15:07:18 +0200 Received: from MTLCAS01.mtl.com (10.0.8.71) by MTLCAS13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Mon, 21 Jan 2019 15:07:18 +0200 Received: from [10.223.0.55] (10.223.0.55) by MTLCAS01.mtl.com (10.0.8.71) with Microsoft SMTP Server (TLS) id 14.3.301.0; Mon, 21 Jan 2019 15:07:10 +0200 Subject: Re: [PATCH v3] nvmet-rdma: fix null dereference under heavy load To: Sagi Grimberg , Christoph Hellwig , Raju Rangoju CC: , , References: <20190103173531.7987-1-rajur@chelsio.com> <20190119133410.GA6963@infradead.org> From: Max Gurtovoy Message-ID: Date: Mon, 21 Jan 2019 15:07:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.223.0.55] X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(396003)(376002)(136003)(39860400002)(2980300002)(199004)(54094003)(189003)(110136005)(186003)(7736002)(305945005)(54906003)(478600001)(58126008)(16526019)(229853002)(316002)(81156014)(16576012)(64126003)(77096007)(3846002)(81166006)(26005)(106466001)(6246003)(50466002)(6116002)(2906002)(336012)(486006)(2616005)(126002)(476003)(53546011)(11346002)(8676002)(446003)(31686004)(356004)(65956001)(4326008)(106002)(76176011)(4744005)(2870700001)(65826007)(67846002)(23676004)(31696002)(2486003)(47776003)(86362001)(36756003)(8936002)(65806001)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DBBPR05MB6427;H:mtlcas13.mtl.com;FPR:;SPF:Pass;LANG:en;PTR:mail13.mellanox.com;A:1;MX:1; X-Microsoft-Exchange-Diagnostics: 1;DB5EUR03FT053;1:gv18EUUL7N5IjaNxqlaB0owtbGTT50JGvcTgUb67VIqz40JNLRB04Z2ImYoBPrLgnblDUs3BNVUKhykNBhQZZzo4/fyn7SmdjsluSpqIl/K0/976oWic7awG23nsIsuX X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b42594a6-a1f4-49b5-a8e6-08d67fa16048 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600109)(711020)(4608076)(4709027)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:DBBPR05MB6427; X-Microsoft-Exchange-Diagnostics: 1;DBBPR05MB6427;3:rJcYtI0zhfS1QGFxxyhRBN1lUdPcI4kDY2rM4sjImaTQdGVrUy3JhiFXcfBUMqqHgzWm+6/lPIsGxeE6Uu3ZE0Z6hEsScCjWDVzsmPZwiE6/cKYI1XX1rJ/yjOqsnBUmBZkNNCBXDWobzK1gSfJd++Y1u53so9rtyvw4qQLjCUDPp3RkE9Zk7ctYFlxyLbzngoxJY6y1lrSFWw/Bfp7t71qYq+L2+g+tCr+MCUf6TNn/drED8EIi94R7wnW28w9LcE0XS9k+sqqc2e+u+v3dgaZAIm3SLLBNmiC0kqeiCSlwY1abiyHCsqSpRcwvnMyVR9A6K8qbNIvn+C13vaGn8YEhyVORr99A+1VpjhEM+rAzH3ykzeIccFsJvGkUrpvy;25:Uk6GchAUuyBdApjA34FqFD9jIwvoPZsmDJPCWJhZrX1kGexyNP0BU2hkx5NJPJiCpZhigIMb6euTL69y4Vi+Hsr9j1Hw0SQK5ECBo5M+QqDwo6nb4yRkJeoDZGK7sjLygFNqzqvvF7blTE6+wJ3Rc1FOZn3ZL7DMln+q2y0N2AU8aF8CV6ZKToSVf1JxNn4ySlf6btlSS81HualogX2ipvukWP9RefTpusZWfqSEe09WHw5okLy8a2xgUwiuM+pe7ehTk6bt1XWsQfD6HWFS0PlRa0VLAH3BDV7+bKjDSufYq8aA6+UJEukUuZ7xALk6yHZ4ARO1MqQ/m8AUSYcgYg== X-MS-TrafficTypeDiagnostic: DBBPR05MB6427: X-Microsoft-Exchange-Diagnostics: 1;DBBPR05MB6427;31:cBKPblnQ0I/1dDczNH8iYh9Ztd4uMiMV5GTrJb6HEvYt4Srm4Rbryg4uavAIo3gq/QZT+gc7CS8s/bYfWoQCnWohwsrcPIYRUebwYH5rmZQXbUz1lhCTuKVrYnJaI8rU7QtkN47PUZRRRExyz1cH1nMWGQrVzJ83b+5358I8TpRki8u9oKrt9ckY/QLK8Rgb7USz33KMz8w5XtiNFwEur521EgBJ91n3xDUyX8xOhIw=;20:lTsuiS3e5YktfTwHtn+skRcDREnTIv8AcVt6MHPA854/SrlIAPyxNCBQtu4hjHrSeeQBtdPmhNBhC/K6JD8E7DjADWfNSGMjXgsTjOg2Uxy9W9bHP/LZUHPi119F7ITb3gGqYwHD51lwkf0fPBlk5hoy/pEftnFUfu6bSpnLZy2nWtneJIx1TT3B6ob+WJSQoBF6VjWR4SUR3iQtNzV0VWORFKwMtZQhoFsVlbp9rVfkroypNsiNpaYGZGcHUo05GBtKag7/2+lABgqSHevXCg4d1yNiBtlSA/9XnsUS+i8LzVLdDtSnTwoZkg13X+Mv6cYgSysPWfwzjwUZyrUW599BBe/gqFgsAmlb/7pUtM65Kn1wTnweWleDFsjhRCZMxfQLQW/9tqBdMeOw9lRM6xZTS+RyARUWt4xGLKx2pvAX0RA/4CbJn4cvHeNCw0rE83ljt4NhJu0tJ1hPM15J3ea6EgL1hQll/Rmdn7LGz04JoQzkZ18MQyUBzfCGBH37 X-Microsoft-Antispam-PRVS: X-Microsoft-Exchange-Diagnostics: 1;DBBPR05MB6427;4:P2FY1jYG+VP+JHIZuDWM625nSfHrP2ySCyMzPCgDO6H+Bk4/O7Iaj5s3cRdmMhX9mzjK6o2lHTWkoLWDhzNrsp2spQ2I69MgxmZqWJR/9frMx5CQrz/b3wpgUpNqaR+h8KS5lApg+nkLDXyCx1eDcqz/ahJoqiy49e1ctHQLgDQ8X8QgGvqD9uJplO3xtjcleUWr/oSoA5DeCU8b/PDG/y3swInppgWfC/+KHbnyEgKCY4W4S8yEo5+sWf2iHDd26PuGeNzsxbfl2o2x1DIoxjC82s+a2qH7M54Lgh0VdC1j7fVPMH8/cBgBz2Mfdxd3 X-Forefront-PRVS: 0924C6A0D5 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQkJQUjA1TUI2NDI3OzIzOkNYWTZtME5zMGNRYU1hclRjWTA0YWNyN05O?= =?utf-8?B?M0FmczhTcjRHcEVPVXRpWUZSa2NMeEFMdEVRblEraWlPVmRsSCtLZXlVY3ZR?= =?utf-8?B?eG4reEhueEtxckNIdlduaGRZZGpwVjVUUVZGTk9zNWViNkYySXlhTEpnd08r?= =?utf-8?B?cFBTd25odnl0VEptMjhZU0d4cG41ZkJwMVlXUEd1MFN4NkVqMlVVTnJER3da?= =?utf-8?B?V2xxcjlVT3BJMDhKYmVLcUJtK09rNmxsY3dUM2NkL2drQWdVWVQ2MDQ1RVBL?= =?utf-8?B?cjk4ekZmTHhqNVRpd1BMd2FRNkxMQ1k0bGo5eVJlMW9JYWtHODNFeHBjbzlt?= =?utf-8?B?dmFxSWwzQTZiNDZ4NWNqTkIwQzV5VEE5MnNDUHJDcUwzb2crOGYxQVhDUEIz?= =?utf-8?B?OUhKK1UycFI1Z09PUENJRUVtY0I5WGdxWDdMc0pSVW9LK04rcXFUaFpyeXJz?= =?utf-8?B?dFVqSlhmcjJNUlAwZ0JqdStpNWJ3NE9ydXZKaDlEbkdIa3ZTSU40MDlva0JM?= =?utf-8?B?MC9uTzQveGtWZloyYTljN2p3ZzBqOHRHOE1IRXV5RmNRSkt3SHpjT3ZWRG5l?= =?utf-8?B?YS9DYlE5cGFOcGlFc0laZVZKUlFPTjhnTXFneVd6VjVtWXJEL1pyK2FlRVMr?= =?utf-8?B?YXhhdFU0Q1c3dVdKOE1tTDdCaDNjUlFrcENteDAwalhaSkF1K1dxaHVoOFJF?= =?utf-8?B?cUlOY3d2aFEzWWxjQkt3d295M2NwWkh3S2dtOGlHNmdGNURBVEo0WlU4dm14?= =?utf-8?B?R0hPcGtYV3oybVcrcVJTRzMwODZld0RnUzNROGY5Wi9aNjJMa1IzSk9ZeDNC?= =?utf-8?B?ZjhHYXdIdHh0K1E5eW1nRmZLSUF6TnBCTUNWRFFQQVgyLy91aWE2SXdMS2x2?= =?utf-8?B?QXhiT0hzNGVXOEkzeGlkVG5pbUpNZmNYNWdUSFJXc1Jvc29ld1NjRXhVVTJh?= =?utf-8?B?SGZ6enYrcWZBZmVHTlkvR24xU1FwRmMyTTZFWkE4WWdsZjI1WExtV2lXSFpM?= =?utf-8?B?bGljOFBjMXFjOXlxUWNOR1hrR1RqWEMyREYzdFJSZHI1MmZSbG0rMW5jV3VX?= =?utf-8?B?RThoMVRibnA0UVVkUDRRZmpJa0FrcWRhSG42dkpxditaSjh1RmppRFYvK0x1?= =?utf-8?B?NjhHYVhIeU1oTHRsVkVWNEY2UCtXT25vbm1jS0JYTGt6OVI3M3FTWUIrcmFM?= =?utf-8?B?MDBpL3lmeGdacUNveGZIdGp3MlhkUGlOdTZJR3NiZWplRjFidk5KZFN6aUph?= =?utf-8?B?Tm1CeDJhZnEyMGVaVVh0eTlwY1gvWW1vY2pxejA0QnY0Zm1LNmFSYU53bS9s?= =?utf-8?B?Ty9NcUtFV2tPQXBDMWFkY3FmemQ3eEV3UVNXS3cybm1LdVdhcWVSRWEzaHdE?= =?utf-8?B?RzlLNXV1d2V6ajMxeWFHNEVPbW9BWENvaVd4UFMxRStMWWdNRUZKak5uNWFi?= =?utf-8?B?M2FUQy9RS2RGWHFEQlM3dUtOQXJjTVUrcGx1b1BFRDRjUGd3MjBVWEY4ZzZp?= =?utf-8?B?ZFlybm05SXR0QmNRQjlKRlJOZlFId0ZZWldtaHFCTEE0OERMekt3QXppYUtH?= =?utf-8?B?alJuc1NCRVk3bmpDV29xMmpVNkFIeXRVRUx6UUFOME0yRHljNEtCbXlGS09J?= =?utf-8?B?MlQvL3B2a3R2SVFPTHVLMkNlNjJkbElYSHNRVVpvbHFzMS9KYXlTZ2dYeTY3?= =?utf-8?B?aVhyOUhPNE5saDFnTjF3cXJmem92Y0RtK0EzbTVwbzZIekNSLzkybVpvTDNB?= =?utf-8?B?V2NoODk3eE5ZNXhJTTBsZz09?= X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: /2SWqWoNmHaUea8PA2LykFlod9Kz8X3gGcx+qzVsCfzP2iuhDYotMikhCC8+eimfYRL6ySMFJIr4hUz9aEv1MIM+iyAgbqtsO3NLQsTE9rv8aN4R0/dOGnsgAC7CNBCCtcuduWX9FwD/TTDUeDbhbZEJKLPQNvEE0hVj4IWNV5WJAKuysGqzkhr8qPa+rXsSNDHaqhjud5lv+0sBbztZ2ZbneChcB/BwMp5OZ0fC12luX55Qmp0dzlTg9+lIYxj2IG4CaJovc6O8/Z5MklL+xS24eN2sOndNBgP3o+ryvsvM2x1SZEJ7y7u3dcMTU2e5ZTCAF3tskYuMxzYBFM4RLkUhHCrAIi58ZcjHDwlO+cem4RlZhdUyiQxaC/6O/418tUWYOf7DF6wXjdzl+Ge7a4VPjnrfJ8iSnpowX7BYppk= X-Microsoft-Exchange-Diagnostics: 1;DBBPR05MB6427;6:4om0CADcavVhreQLDwTqkVmqIlVQuwNlO7s3ELGnkwKUuf2FBkS7jzSIWgwCSmkgd55JKdLkXAHiiIxssepBz2xcZhQexUTH7+ZTi1axSp0D3DmpylNfyUcTDAcv6oJ4nQW3jRieyrprCXCAPpY1a0xea+CrI9e0/AEfshMdNQ4lcSsY1q1M3P5O3wI3VfBJdQgVzj1nm4st3GMlnaOfQ5eGAjgtPRc2bQ5xXYTb1yPRwRZz9Xmzw0LkGIoOCK/KpiXlYUUOHHBXQdLSAz2oTQ8Yudz0tDvt1hfdGSNSQKyrFCZno2YqpmtWyV7aWxcX8IPo+Y7azCwJvtWErJAgbn7Xc03uh7Y2YSv9ZM3PVrqjz+pFHrOkDkRBa1ld3Z60ZuY0TX9D1tXH6l1GCNL1YnvDC/nvLwlELHZrFaNvgmd3T1ZzGrAsOjnYHdsJW+0aqyrmMv1U9jrYT3tn6fDpTg==;5:JVhvlqBcXEWgRbMd8nMFREsgIKeyGqrKKVo6ry37DWT3ZJgO4n9MOsLT1qGWFfwBYaLZ+Mp5teTO0qymE+q125Wx1/3egURxwDZwBwHn5qTezWlceBBL23eKx/zPh3Lh0GvfYbtMOd+PuBLigRrfCS0TnsBR0vUsB1ZALQBxCqHFfnXoyRSDgDbe7NKKrCbVYJtJbkg7FA2oihqZvfE2sQ==;7:+xr8FfHqe/fS5qWMZsX/xusR8lBADYiaAP4XTPyvUKBDTG4CSqYov3s620pQi/arbOxKqwaQEbwxAAtMQTUwOWsvxTGzns9ERPm7UPuHFn7FWdnIriaZMbfaIEnSPkDhAXl06mnBy2oR+bkws5YWJw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2019 13:07:19.9153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b42594a6-a1f4-49b5-a8e6-08d67fa16048 X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR05MB6427 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 1/21/2019 11:10 AM, Sagi Grimberg wrote: >> This looks ok to me: >> >> Reviewed-by: Christoph Hellwig > > Applied to nvme-5.0 > >> In the long run I wonder if we should get rid of the Ρ•tatic >> preallocation entirely and just use a free pool to avoid constant >> reallocations.. > > you mean a kmem_cache? very possible, we can also make the command > struct to contain the rsp behind it to avoid the extra allocation... yes, the container idea sounds good..