From: Palmer Dabbelt <palmerdabbelt@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: alex@ghiti.fr, jszhang@kernel.org, kernel@esmil.dk,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] riscv: Get rid of CONFIG_PHYS_RAM_BASE in kernel physical" failed to apply to 5.13-stable tree
Date: Tue, 10 Aug 2021 08:07:58 -0700 (PDT) [thread overview]
Message-ID: <mhng-6aba8a9e-0527-47a3-8f64-128a9f7e8342@palmerdabbelt-glaptop> (raw)
In-Reply-To: <YRJIXUxK3vn7h+W3@kroah.com>
On Tue, 10 Aug 2021 02:35:25 PDT (-0700), Greg KH wrote:
> On Tue, Aug 10, 2021 at 10:26:31AM +0200, Alex Ghiti wrote:
>> Hi Greg,
>>
>> Le 9/08/2021 à 12:42, gregkh@linuxfoundation.org a écrit :
>> >
>> > The patch below does not apply to the 5.13-stable tree.
>>
>> I don't know when stable was cc on this patch, this fixes something
>> introduced in 5.14-rc1, so this is not normal it can't be applied.
>>
>> Sorry for the noise,
>>
>> Alex
>>
>> > If someone wants it applied there, or to any other stable or longterm
>> > tree, then please email the backport, including the original git commit
>> > id to <stable@vger.kernel.org>.
>> >
>> > thanks,
>> >
>> > greg k-h
>> >
>> > ------------------ original commit in Linus's tree ------------------
>> >
>> > From 6d7f91d914bc90a15ebc426440c26081337ceaa1 Mon Sep 17 00:00:00 2001
>> > From: Alexandre Ghiti <alex@ghiti.fr>
>> > Date: Wed, 21 Jul 2021 09:59:35 +0200
>> > Subject: [PATCH] riscv: Get rid of CONFIG_PHYS_RAM_BASE in kernel physical
>> > address conversion
>> >
>> > The usage of CONFIG_PHYS_RAM_BASE for all kernel types was a mistake:
>> > this value is implementation-specific and this breaks the genericity of
>> > the RISC-V kernel.
>> >
>> > Fix this by introducing a new variable phys_ram_base that holds this
>> > value at runtime and use it in the kernel physical address conversion
>> > macro. Since this value is used only for XIP kernels, evaluate it only if
>> > CONFIG_XIP_KERNEL is set which in addition optimizes this macro for
>> > standard kernels at compile-time.
>> >
>> > Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
>> > Tested-by: Emil Renner Berthing <kernel@esmil.dk>
>> > Reviewed-by: Jisheng Zhang <jszhang@kernel.org>
>> > Fixes: 44c922572952 ("RISC-V: enable XIP")
>
> But this commit id is in 5.13, is that incorrect?
I wasn't sure what to do here: IMO this fixes a bug that was there the
whole time, it's just not one that actually manifests until the
refactoring. I figured I'd put the farther back tag just to be safe, in
case someone had picked up the feature (more likely a distro tree, but
IIUC they're also looking here).
next prev parent reply other threads:[~2021-08-10 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 10:42 FAILED: patch "[PATCH] riscv: Get rid of CONFIG_PHYS_RAM_BASE in kernel physical" failed to apply to 5.13-stable tree gregkh
2021-08-10 8:26 ` Alex Ghiti
2021-08-10 9:35 ` Greg KH
2021-08-10 15:07 ` Palmer Dabbelt [this message]
2021-08-10 20:14 ` Alex Ghiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-6aba8a9e-0527-47a3-8f64-128a9f7e8342@palmerdabbelt-glaptop \
--to=palmerdabbelt@google.com \
--cc=alex@ghiti.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jszhang@kernel.org \
--cc=kernel@esmil.dk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).