From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47859C43603 for ; Fri, 20 Dec 2019 22:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 164D42146E for ; Fri, 20 Dec 2019 22:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576879309; bh=n9oNlltpSptNjDnyqZpS9pIx39qYhYcQaY7bQ+SruUE=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=yC4fRlUP1oPNCMSRf4WHKAIaPPUfMEPIL14XBrvyMrsGRa2vOViLMDLx0U/cZ2Npq MH4EVBvufINC6LaOe4F0J5HCcQJyVLUXPpwWjosZtLUfeNkm8n62jZkQ3uWSmKsJN8 HH6PkmY4n0rrtQEnynwKtM3BObsZfiBfWFQnAQ7s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727478AbfLTWBs (ORCPT ); Fri, 20 Dec 2019 17:01:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:33152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727473AbfLTWBs (ORCPT ); Fri, 20 Dec 2019 17:01:48 -0500 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93EB32082E; Fri, 20 Dec 2019 22:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576879307; bh=n9oNlltpSptNjDnyqZpS9pIx39qYhYcQaY7bQ+SruUE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bHGFRGRKGY6aPTeZYj9OSOzhqx8EkfSNzD/GXH5eWu6wSXMQ8Mg3IBQVefBhXlAoz phD3I7zDMZ238iMPGt6ZulqL3xt9PnuM1dnc1izTsqODSOJO57m9jBZoMYVk+c7dGY slLHGZvfmL5DhxnAwCNJalrOtJp8WY5Ph2u14D9c= Date: Fri, 20 Dec 2019 23:01:43 +0100 (CET) From: Jiri Kosina To: Arnd Bergmann cc: Thomas Gleixner , Pavel Machek , Josh Poimboeuf , "Rafael J. Wysocki" , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Ingo Molnar , Valentin Schneider , Zhenzhong Duan , Tyler Hicks , linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpu/SMT: fix x86 link error without CONFIG_SYSFS In-Reply-To: Message-ID: References: <20191210195614.786555-1-arnd@arndb.de> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, 10 Dec 2019, Jiri Kosina wrote: > > When CONFIG_SYSFS is disabled, but CONFIG_HOTPLUG_SMT is enabled, > > the kernel fails to link: > > I wonder where such kernels are running ... or I rather don't :) > > > arch/x86/power/cpu.o: In function `hibernate_resume_nonboot_cpu_disable': > > (.text+0x38d): undefined reference to `cpuhp_smt_enable' > > arch/x86/power/hibernate.o: In function `arch_resume_nosmt': > > hibernate.c:(.text+0x291): undefined reference to `cpuhp_smt_enable' > > hibernate.c:(.text+0x29c): undefined reference to `cpuhp_smt_disable' > > > > Move the exported functions out of the #ifdef section into its > > own with the correct conditions. > > > > The patch that caused this is marked for stable backports, so > > this one may need to be backported as well. > > > > Fixes: ec527c318036 ("x86/power: Fix 'nosmt' vs hibernation triple fault during resume") > > Reviewed-by: Jiri Kosina > > Thanks for fixing my oversight. Is anyone going to pick this up please? Thanks, -- Jiri Kosina SUSE Labs