From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86FFC4338F for ; Thu, 12 Aug 2021 11:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8781060F91 for ; Thu, 12 Aug 2021 11:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236862AbhHLLlR (ORCPT ); Thu, 12 Aug 2021 07:41:17 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:57952 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236700AbhHLLlR (ORCPT ); Thu, 12 Aug 2021 07:41:17 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 801741FF36; Thu, 12 Aug 2021 11:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628768451; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YnHuWt0+f9SfIW9jTpudWKoPMyEwl0+rUfJY9MN6hKM=; b=fOIBwLzykcgF4UY5YnxbALKzhKAAmfTLh+SsvNbnUfqcceuG0ba4pDxKnp8WFLmXrMAI4p E1t89nwuMGLJRwk2rZFEvp2qHYZA4UzH6TIVe7SyqI3OpKpbjsoeYHGei9PabWJ6VBhDvO Vt7z9GlG6T66c0dG+ITpyNMtQgdKh8Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628768451; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YnHuWt0+f9SfIW9jTpudWKoPMyEwl0+rUfJY9MN6hKM=; b=BZeWaT82TN9eLpAAQpeYIOB7GoPzEEQ6EAPsOtma7sRZdi+wHsvg1g/xbDKUv9acqIJ5Io W81TDteHFq5EyyDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 577D4A3EF2; Thu, 12 Aug 2021 11:40:51 +0000 (UTC) Date: Thu, 12 Aug 2021 13:40:51 +0200 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Cc: clemens@ladisch.de, alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: oxfw: fix functioal regression for silence in Apogee Duet FireWire In-Reply-To: <20210812022839.42043-1-o-takashi@sakamocchi.jp> References: <20210812022839.42043-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 12 Aug 2021 04:28:39 +0200, Takashi Sakamoto wrote: > > OXFW 971 has no function to use the value in syt field of received > isochronous packet for playback timing generation. In kernel prepatch for > v5.14, ALSA OXFW driver got change to send NO_INFO value in the field > instead of actual timing value. The change brings Apogee Duet FireWire to > generate no playback sound, while output meter moves. > > As long as I investigate, _any_ value in the syt field takes the device to > generate sound. It's reasonable to think that the device just ignores data > blocks in packet with NO_INFO value in its syt field for audio data > processing. > > This commit adds a new flag for the quirk to fix regression. > > Fixes: 029ffc429440 ("ALSA: oxfw: perform sequence replay for media clock recovery") > Cc: > Signed-off-by: Takashi Sakamoto Applied now. Thanks. Takashi