From: Takashi Iwai <tiwai@suse.de>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Takashi Iwai" <tiwai@suse.de>,
"José Expósito" <jose.exposito89@gmail.com>,
linux-input@vger.kernel.org,
"Peter Hutterer" <peter.hutterer@who-t.net>,
"Jiri Kosina" <jkosina@suse.cz>,
stable@vger.kernel.org, regressions@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] Right touchpad button disabled on Dell 7750
Date: Sat, 19 Mar 2022 09:10:57 +0100 [thread overview]
Message-ID: <s5hlex61hwu.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAO-hwJK8QMjYhQAC8tp7hLWZjSB3JMBJXgpKmFZRSEqPUn3_iw@mail.gmail.com>
On Fri, 18 Mar 2022 15:06:55 +0100,
Benjamin Tissoires wrote:
>
> As noticed on the libinput bug, I think the patch is wrong (not by a lot).
> We should base the class on MT_CLS_WIN8, not MT_CLS_DEFAULT.
>
> The testers might say that it's working, but this might create some
> corner cases where it's not leading to more and more headaches with
> your users.
Indeed the first patch caused the wrong button mapping.
Jose's revised patch was confirmed to work fine.
thanks,
Takashi
next prev parent reply other threads:[~2022-03-19 8:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 11:42 [REGRESSION] Right touchpad button disabled on Dell 7750 Takashi Iwai
2022-03-18 13:07 ` José Expósito
2022-03-18 13:11 ` Takashi Iwai
2022-03-18 14:06 ` Benjamin Tissoires
2022-03-18 14:28 ` José Expósito
2022-03-18 14:37 ` Takashi Iwai
2022-03-18 16:05 ` José Expósito
2022-03-18 22:01 ` [PATCH] HID: multitouch: fix Dell Precision 7550 and 7750 button type kernel test robot
2022-03-19 8:10 ` Takashi Iwai [this message]
2022-03-20 19:12 ` [REGRESSION] Right touchpad button disabled on Dell 7750 José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlex61hwu.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).