From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:47703 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbbG3SqN (ORCPT ); Thu, 30 Jul 2015 14:46:13 -0400 To: Stefan Lippers-Hollmann Cc: , martin.petersen@oracle.com, hare@suse.de, tj@kernel.org, Subject: Re: Patch "libata: Fall back to unqueued READ LOG EXT if the DMA variant fails" has been added to the 4.1-stable tree From: "Martin K. Petersen" References: <1438215953336@kroah.com> <20150730195221.6fc1beb8@mir> Date: Thu, 30 Jul 2015 14:45:59 -0400 In-Reply-To: <20150730195221.6fc1beb8@mir> (Stefan Lippers-Hollmann's message of "Thu, 30 Jul 2015 19:52:21 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: >>>>> "Stefan" == Stefan Lippers-Hollmann writes: Greg, Please queue eab6ee1ce3c4. -- Martin K. Petersen Oracle Linux Engineering commit eab6ee1ce3c4678224d70338134f7a02005768cb Author: Martin K. Petersen Date: Tue May 19 19:44:17 2015 -0400 libata: Fix regression when the NCQ Send and Receive log page is absent Commit 5d3abf8ff67f ("libata: Fall back to unqueued READ LOG EXT if the DMA variant fails") allowed us to fall back to the unqueued READ LOG variant if the queued version failed. However, if the device did not support the page at all we would end up looping due to a merge snafu. Ensure we only take the fallback path once. Signed-off-by: Martin K. Petersen Reported-by: Sergey Senozhatsky Tested-by: Sergey Senozhatsky Signed-off-by: Tejun Heo diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index 2893563d0537..2b370ee0ae86 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -1521,6 +1521,7 @@ retry: } else { tf.command = ATA_CMD_READ_LOG_EXT; tf.protocol = ATA_PROT_PIO; + dma = false; } tf.lbal = log; tf.lbam = page;