stgt.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Duncan <lduncan@suse.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>, stgt@vger.kernel.org
Subject: backing-store modules directory not present is not an error
Date: Sun, 15 Nov 2015 17:15:51 -0800	[thread overview]
Message-ID: <56492E47.2010108@suse.com> (raw)
In-Reply-To: <20151114.214659.1568838937885775323.fujita.tomonori@lab.ntt.co.jp>

The backing-store modules directory, normally
/usr/lib/tgt/backing-store, is not created, needed, or used when there
are no backing store modules. So change the error message printed when
the directory is not present to a debug message.

Signed-off-by: Lee Duncan <lduncan@suse.com>
---
diff -aurp tgt-1.0.44.orig/usr/bs.c tgt-1.0.44/usr/bs.c
--- tgt-1.0.44.orig/usr/bs.c	2014-02-02 22:56:32.000000000 -0800
+++ tgt-1.0.44/usr/bs.c	2015-11-15 17:14:51.932000000 -0800
@@ -267,7 +267,8 @@ static int bs_init_signalfd(void)

 	dir = opendir(BSDIR);
 	if (dir == NULL) {
-		eprintf("could not open backing-store module directory %s\n",
+		/* not considered an error if there are no modules */
+		dprintf("could not open backing-store module directory %s\n",
 			BSDIR);
 	} else {
 		struct dirent *dirent;

  reply	other threads:[~2015-11-16  1:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 19:36 Bug: "could not open backing-store directory: /usr/lib/tgt/backing-store" message at startup Lee Duncan
2015-11-14 12:46 ` FUJITA Tomonori
2015-11-16  1:15   ` Lee Duncan [this message]
2015-11-19  0:43     ` backing-store modules directory not present is not an error FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56492E47.2010108@suse.com \
    --to=lduncan@suse.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=stgt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).