From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A9AC433FC for ; Mon, 29 Mar 2021 22:30:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BAA9601FC for ; Mon, 29 Mar 2021 22:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232509AbhC2War (ORCPT ); Mon, 29 Mar 2021 18:30:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:48398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232389AbhC2WYX (ORCPT ); Mon, 29 Mar 2021 18:24:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 481F7619C4; Mon, 29 Mar 2021 22:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617056620; bh=/frcPlRyDh7HrKhiF9X0DH5goxXEtcstRp0HjSuhiJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DlYZLIo0qna1txLmXou/9VUnZIY1xOfFi8l3dyqJ3jB9P1kcEuvdwuGi9sll7uUDy cC/N8b/+M4qkeFQq+QCU6LwSGv9d//EvUsD7e3sre8CAUYFSH0bZ0+pDfM5jXis7b/ 9UNCG60fDzt2ACaW0PTNeCvYrGbG7ZNgfVlEp0icCFrnh5yQaa9U6K3x8lRmfeIXxu b69N+dGn7Jc5M0Tb6RlD9YubecMHzhtfRNQ881+wmVz3wq1FAYlrxBE55RhIPOQSZK vg1kRp6mhE6jVlB9kVZuyty1lVC1HGjtDCfKJVKfGgZQLJhKaHaE9L4JY6O9iKkPdk vXO735U0F2fdQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Martin Wilck , Christoph Hellwig , Lee Duncan , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 11/15] scsi: target: pscsi: Clean up after failure in pscsi_map_sg() Date: Mon, 29 Mar 2021 18:23:22 -0400 Message-Id: <20210329222327.2383533-11-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210329222327.2383533-1-sashal@kernel.org> References: <20210329222327.2383533-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org From: Martin Wilck [ Upstream commit 36fa766faa0c822c860e636fe82b1affcd022974 ] If pscsi_map_sg() fails, make sure to drop references to already allocated bios. Link: https://lore.kernel.org/r/20210323212431.15306-2-mwilck@suse.com Reviewed-by: Christoph Hellwig Reviewed-by: Lee Duncan Signed-off-by: Martin Wilck Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_pscsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index 47d76c862014..02c4e3beb264 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c @@ -970,6 +970,14 @@ pscsi_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, return 0; fail: + if (bio) + bio_put(bio); + while (req->bio) { + bio = req->bio; + req->bio = bio->bi_next; + bio_put(bio); + } + req->biotail = NULL; return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; } -- 2.30.1