From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4126C433B4 for ; Sat, 15 May 2021 23:05:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9493461283 for ; Sat, 15 May 2021 23:05:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbhEOXGL (ORCPT ); Sat, 15 May 2021 19:06:11 -0400 Received: from mga18.intel.com ([134.134.136.126]:61989 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231145AbhEOXGK (ORCPT ); Sat, 15 May 2021 19:06:10 -0400 IronPort-SDR: kuuK/1YcMcIvJ/JqUlM3SIh2a6vqcjL1YLONADy+2vP7ZoscMBzdaMUN5i4XsRYr99HHQVtNVL P9HpcWr01+eQ== X-IronPort-AV: E=McAfee;i="6200,9189,9985"; a="187711665" X-IronPort-AV: E=Sophos;i="5.82,303,1613462400"; d="scan'208";a="187711665" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2021 16:04:56 -0700 IronPort-SDR: dTzY40K2PPtxpGISSC9WzZJN+3mfHCBBT9fhEbE5zxG//41aCH6QVzTQZJh4fDfsedR4XsEdTQ X4bbKAQeN3DA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,303,1613462400"; d="scan'208";a="472093815" Received: from lkp-server01.sh.intel.com (HELO ddd90b05c979) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 15 May 2021 16:04:54 -0700 Received: from kbuild by ddd90b05c979 with local (Exim 4.92) (envelope-from ) id 1li3L3-0001HC-Th; Sat, 15 May 2021 23:04:53 +0000 Date: Sun, 16 May 2021 07:03:58 +0800 From: kernel test robot To: Bodo Stroesser Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH] scsi: target: tcmu: fix boolreturn.cocci warnings Message-ID: <20210515230358.GA97544@60d1edce16e0> References: <202105160749.IImZN2gL-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202105160749.IImZN2gL-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org From: kernel test robot drivers/target/target_core_user.c:1424:9-10: WARNING: return of 0/1 in function 'tcmu_handle_completions' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 9814b55cde05 ("scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found") CC: Bodo Stroesser Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c12a29ed9094b4b9cde8965c12850460b9a79d7c commit: 9814b55cde0588b6d9bc496cee43f87316cbc6f1 scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found :::::: branch date: 6 hours ago :::::: commit date: 2 weeks ago target_core_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1421,7 +1421,7 @@ static bool tcmu_handle_completions(stru if (test_bit(TCMU_DEV_BIT_BROKEN, &udev->flags)) { pr_err("ring broken, not handling completions\n"); - return 0; + return false; } mb = udev->mb_addr;