target-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: martin.petersen@oracle.com
Subject: Missing message prefix in target_core_device.c
Date: Wed, 30 Jun 2021 15:50:26 +0200	[thread overview]
Message-ID: <20210630135026.GP2610@twin.jikos.cz> (raw)

Hi,

I've noticed that after loading the target core there's a message in
syslog

  "Rounding down aligned max_sectors from 4294967295 to 4294967288"

but without a prefix, printed from drivers/target/target_core_device.c.
It's pr_info so the prefix should be defined at the top of the file as
pr_fmt and it'll be picked by the pr_* macros automatically.

I'm not sending a patch as I don't know what would be the preferred
prefix, eg. drivers/target/target_core_user.c prints "tcmu daemon" but
does not use pr_*, and there are several bare printk calls in the same
file.  This should be unified in some way but I'm not familiar with the
target code.

d.

             reply	other threads:[~2021-06-30 13:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 13:50 David Sterba [this message]
2021-07-19  1:03 ` Missing message prefix in target_core_device.c Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210630135026.GP2610@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).