From: Dmitry Bogdanov <d.bogdanov@yadro.com>
To: Martin Petersen <martin.petersen@oracle.com>,
<target-devel@vger.kernel.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
James Smart <james.smart@broadcom.com>,
Ram Vegesna <ram.vegesna@broadcom.com>,
Michael Cyr <mikecyr@linux.ibm.com>,
Nilesh Javali <njavali@marvell.com>,
<GR-QLogic-Storage-Upstream@marvell.com>,
Chris Boot <bootc@bootc.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Juergen Gross <jgross@suse.com>,
<linux-scsi@vger.kernel.org>, <linux@yadro.com>,
Dmitry Bogdanov <d.bogdanov@yadro.com>
Subject: [PATCH v2 02/12] infiniband: srpt: remove default fabric ops callouts
Date: Tue, 7 Mar 2023 11:07:32 +0300 [thread overview]
Message-ID: <20230307080742.24631-3-d.bogdanov@yadro.com> (raw)
In-Reply-To: <20230307080742.24631-1-d.bogdanov@yadro.com>
Remove callouts that have the implementation like a
default implementation in TCM Core.
Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
---
drivers/infiniband/ulp/srpt/ib_srpt.c | 33 ---------------------------
1 file changed, 33 deletions(-)
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 3c3fae738c3e..3e9343fd2d8e 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -3300,11 +3300,6 @@ static int srpt_check_true(struct se_portal_group *se_tpg)
return 1;
}
-static int srpt_check_false(struct se_portal_group *se_tpg)
-{
- return 0;
-}
-
static struct srpt_port *srpt_tpg_to_sport(struct se_portal_group *tpg)
{
return tpg->se_tpg_wwn->priv;
@@ -3334,11 +3329,6 @@ static u16 srpt_get_tag(struct se_portal_group *tpg)
return 1;
}
-static u32 srpt_tpg_get_inst_index(struct se_portal_group *se_tpg)
-{
- return 1;
-}
-
static void srpt_release_cmd(struct se_cmd *se_cmd)
{
struct srpt_send_ioctx *ioctx = container_of(se_cmd,
@@ -3378,24 +3368,6 @@ static void srpt_close_session(struct se_session *se_sess)
srpt_disconnect_ch_sync(ch);
}
-/**
- * srpt_sess_get_index - return the value of scsiAttIntrPortIndex (SCSI-MIB)
- * @se_sess: SCSI target session.
- *
- * A quote from RFC 4455 (SCSI-MIB) about this MIB object:
- * This object represents an arbitrary integer used to uniquely identify a
- * particular attached remote initiator port to a particular SCSI target port
- * within a particular SCSI target device within a particular SCSI instance.
- */
-static u32 srpt_sess_get_index(struct se_session *se_sess)
-{
- return 0;
-}
-
-static void srpt_set_default_node_attrs(struct se_node_acl *nacl)
-{
-}
-
/* Note: only used from inside debug printk's by the TCM core. */
static int srpt_get_tcm_cmd_state(struct se_cmd *se_cmd)
{
@@ -3866,18 +3838,13 @@ static const struct target_core_fabric_ops srpt_template = {
.fabric_name = "srpt",
.tpg_get_wwn = srpt_get_fabric_wwn,
.tpg_get_tag = srpt_get_tag,
- .tpg_check_demo_mode = srpt_check_false,
.tpg_check_demo_mode_cache = srpt_check_true,
.tpg_check_demo_mode_write_protect = srpt_check_true,
- .tpg_check_prod_mode_write_protect = srpt_check_false,
- .tpg_get_inst_index = srpt_tpg_get_inst_index,
.release_cmd = srpt_release_cmd,
.check_stop_free = srpt_check_stop_free,
.close_session = srpt_close_session,
- .sess_get_index = srpt_sess_get_index,
.sess_get_initiator_sid = NULL,
.write_pending = srpt_write_pending,
- .set_default_node_attributes = srpt_set_default_node_attrs,
.get_cmd_state = srpt_get_tcm_cmd_state,
.queue_data_in = srpt_queue_data_in,
.queue_status = srpt_queue_status,
--
2.25.1
next prev parent reply other threads:[~2023-03-07 8:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 8:07 [PATCH v2 00/12] add virtual remote fabric Dmitry Bogdanov
2023-03-07 8:07 ` [PATCH v2 01/12] scsi: target: add default fabric ops callaouts Dmitry Bogdanov
2023-03-07 8:07 ` Dmitry Bogdanov [this message]
2023-03-07 8:07 ` [PATCH v2 03/12] scsi: ibmvscsit: remove default fabric ops callouts Dmitry Bogdanov
2023-03-07 8:07 ` [PATCH v2 04/12] scsi: target: loop: " Dmitry Bogdanov
2023-03-07 8:07 ` [PATCH v2 05/12] scsi: target: sbp: " Dmitry Bogdanov
2023-03-07 8:07 ` [PATCH v2 06/12] scsi: target: fcoe: " Dmitry Bogdanov
2023-03-07 8:07 ` [PATCH v2 07/12] usb: gadjet: f_tcm: " Dmitry Bogdanov
2023-03-10 22:08 ` Mike Christie
2023-03-07 8:07 ` [PATCH v2 08/12] vhost-scsi: " Dmitry Bogdanov
2023-03-07 8:07 ` [PATCH v2 09/12] xen-scsiback: " Dmitry Bogdanov
2023-03-07 8:44 ` Juergen Gross
2023-03-07 8:07 ` [PATCH v2 10/12] scsi: qla2xxx: " Dmitry Bogdanov
2023-03-07 8:07 ` [PATCH v2 11/12] scsi: efct: " Dmitry Bogdanov
2023-03-07 8:07 ` [PATCH v2 12/12] target: add virtual remote target Dmitry Bogdanov
2023-03-10 22:32 ` Mike Christie
2023-03-13 14:13 ` Dmitry Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307080742.24631-3-d.bogdanov@yadro.com \
--to=d.bogdanov@yadro.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=bootc@bootc.net \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.smart@broadcom.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=leon@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=mikecyr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=njavali@marvell.com \
--cc=ram.vegesna@broadcom.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).