From: Dmitry Bogdanov <d.bogdanov@yadro.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
<target-devel@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
James Smart <james.smart@broadcom.com>,
Ram Vegesna <ram.vegesna@broadcom.com>,
Michael Cyr <mikecyr@linux.ibm.com>,
Nilesh Javali <njavali@marvell.com>,
<GR-QLogic-Storage-Upstream@marvell.com>,
Chris Boot <bootc@bootc.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Juergen Gross <jgross@suse.com>,
<linux-scsi@vger.kernel.org>, <linux@yadro.com>,
Konstantin Shelekhin <k.shelekhin@yadro.com>
Subject: Re: [PATCH v3 12/12] target: add virtual remote target
Date: Wed, 15 Mar 2023 10:59:04 +0300 [thread overview]
Message-ID: <20230315075904.GC1031@yadro.com> (raw)
In-Reply-To: <c004e7a8-8478-cc75-e174-5c0bbd22f4fc@oracle.com>
On Tue, Mar 14, 2023 at 12:09:31PM -0500, Mike Christie wrote:
>
> On 3/13/23 1:11 PM, Dmitry Bogdanov wrote:
> > +
> > +static int tcm_remote_port_link(
> > + struct se_portal_group *se_tpg,
> > + struct se_lun *lun)
> > +{
i>
> Oh no, what happened. Something probably got messed up in your patch
> management because I saw the 0/12 patch said the coding style was
> fixed up.
>
> If Martin will take a follow up patch or it's not a big deal to him,
> I'm ok.
>
> Reviewed-by: Mike Christie <michael.christie@oracle.com>
>
Mike, the code style is the same as in v2. AFAIR you said not to mix
the first function argument in the same line with the first argument in
the next line. In my patch there is no such mix anymore. Either all
arguments are inline or all arguments in the next lines.
next prev parent reply other threads:[~2023-03-15 7:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 18:10 [PATCH v3 00/12] add virtual remote fabric Dmitry Bogdanov
2023-03-13 18:10 ` [PATCH v3 01/12] scsi: target: add default fabric ops callaouts Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 02/12] infiniband: srpt: remove default fabric ops callouts Dmitry Bogdanov
2023-03-13 20:19 ` Bart Van Assche
2023-03-13 18:11 ` [PATCH v3 03/12] scsi: ibmvscsit: " Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 04/12] scsi: target: loop: " Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 05/12] scsi: target: sbp: " Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 06/12] scsi: target: fcoe: " Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 07/12] usb: gadget: f_tcm: " Dmitry Bogdanov
2023-03-13 18:29 ` Greg Kroah-Hartman
2023-03-13 18:11 ` [PATCH v3 08/12] vhost-scsi: " Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 09/12] xen-scsiback: " Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 10/12] scsi: qla2xxx: " Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 11/12] scsi: efct: " Dmitry Bogdanov
2023-03-13 18:11 ` [PATCH v3 12/12] target: add virtual remote target Dmitry Bogdanov
2023-03-14 17:09 ` Mike Christie
2023-03-15 7:59 ` Dmitry Bogdanov [this message]
2023-03-15 16:13 ` Mike Christie
2023-03-17 3:41 ` [PATCH v3 00/12] add virtual remote fabric Martin K. Petersen
2023-03-24 21:06 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315075904.GC1031@yadro.com \
--to=d.bogdanov@yadro.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=bootc@bootc.net \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.smart@broadcom.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=k.shelekhin@yadro.com \
--cc=leon@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mikecyr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=njavali@marvell.com \
--cc=ram.vegesna@broadcom.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).