From: James Smart <jsmart2021@gmail.com>
To: Colin King <colin.king@canonical.com>,
James Smart <james.smart@broadcom.com>,
Ram Vegesna <ram.vegesna@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: elx: efct: remove redundant initialization of variable lun
Date: Fri, 18 Jun 2021 15:50:27 -0700 [thread overview]
Message-ID: <3be6287a-9ac3-2837-11b2-a0270522a607@gmail.com> (raw)
In-Reply-To: <20210616171621.16176-1-colin.king@canonical.com>
On 6/16/2021 10:16 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable lun is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/elx/efct/efct_unsol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
next prev parent reply other threads:[~2021-06-18 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 17:16 [PATCH][next] scsi: elx: efct: remove redundant initialization of variable lun Colin King
2021-06-18 22:50 ` James Smart [this message]
2021-06-19 2:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3be6287a-9ac3-2837-11b2-a0270522a607@gmail.com \
--to=jsmart2021@gmail.com \
--cc=colin.king@canonical.com \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ram.vegesna@broadcom.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).