From: Bart Van Assche <bvanassche@acm.org>
To: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>
Cc: Maor Gottlieb <maorg@nvidia.com>,
linux-rdma@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH rdma-next v2] IB/srpt: Fix memory leak in srpt_add_one
Date: Thu, 29 Oct 2020 03:31:59 +0000
Message-ID: <620b6f78-c3e2-a9ab-5942-36cc2b7fe32e@acm.org> (raw)
In-Reply-To: <20201028065051.112430-1-leon@kernel.org>
On 10/27/20 11:50 PM, Leon Romanovsky wrote:
> Failure in srpt_refresh_port() for the second port will leave MAD
> registered for the first one, however, the srpt_add_one() will be
> marked as "failed" and SRPT will leak resources for that registered
> but not used and released first port.
>
> Unregister the MAD agent for all ports in case of failure.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply index
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 6:50 Leon Romanovsky
2020-10-29 3:31 ` Bart Van Assche [this message]
2020-11-02 19:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=620b6f78-c3e2-a9ab-5942-36cc2b7fe32e@acm.org \
--to=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Target-devel archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/target-devel/0 target-devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 target-devel target-devel/ https://lore.kernel.org/target-devel \
target-devel@vger.kernel.org
public-inbox-index target-devel
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.target-devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git