From: James Smart <jsmart2021@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>,
James Smart <james.smart@broadcom.com>,
Ram Vegesna <ram.vegesna@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()
Date: Fri, 18 Jun 2021 15:54:26 -0700 [thread overview]
Message-ID: <7afb1139-79d8-57b6-b629-bc0a0d142687@gmail.com> (raw)
In-Reply-To: <20210617063123.21239-1-nathan@kernel.org>
On 6/16/2021 11:31 PM, Nathan Chancellor wrote:
> clang warns:
>
> drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
> 'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
> (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
> ~~~~~~^~~
>
> buf is an array in the middle of a struct so deferencing it is not a
> problem as long as ctx is not NULL. Eliminate the check, which fixes the
> warning.
>
> Fixes: 580c0255e4ef ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1398
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/scsi/elx/efct/efct_hw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks!
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
next prev parent reply other threads:[~2021-06-18 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 6:31 [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel() Nathan Chancellor
2021-06-18 22:54 ` James Smart [this message]
2021-06-19 2:32 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7afb1139-79d8-57b6-b629-bc0a0d142687@gmail.com \
--to=jsmart2021@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ram.vegesna@broadcom.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).