From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Le Moal Date: Mon, 12 Oct 2020 02:30:18 +0000 Subject: Re: [PATCH RFC PKS/PMEM 26/58] fs/zonefs: Utilize new kmap_thread() Message-Id: List-Id: References: <20201009195033.3208459-1-ira.weiny@intel.com> <20201009195033.3208459-27-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "ira.weiny@intel.com" , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski , Peter Zijlstra Cc: "linux-aio@kvack.org" , "linux-efi@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "kexec@lists.infradead.org" , Dave Hansen , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "target-devel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linux-kselftest@vger.kernel.org" , "samba-technical@lists.samba.org" , "ceph-devel@vger.kernel.org" , "drbd-dev@lists.linbit.com" , Naohiro Aota , "linux-cifs@vger.kernel.org" , "linux-nilfs@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "linux-rdma@vger.kernel.org" , "x86@kernel.org" , "amd-gfx@lists.freedesktop.org" , "linux-afs@lists.infradead.org" , "cluster-devel@redhat.com" , "linux-cachefs@redhat.com" , "intel-wired-lan@lists.osuosl.org" , "xen-devel@lists.xenproject.org" , "linux-ext4@vger.kernel.org" , Fenghua Yu , "devel@driverdev.osuosl.org" , "linux-um@lists.infradead.org" , "intel-gfx@lists.freedesktop.org" , "ecryptfs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , "reiserfs-devel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-bcache@vger.kernel.org" , Dan Williams , "io-uring@vger.kernel.org" , "linux-nfs@vger.kernel.org" , "linux-ntfs-dev@lists.sourceforge.net" , "netdev@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-fsdevel@vger.kernel.org" , "bpf@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-btrfs@vger.kernel.org" On 2020/10/10 4:52, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Damien Le Moal > Cc: Naohiro Aota > Signed-off-by: Ira Weiny > --- > fs/zonefs/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c > index 8ec7c8f109d7..2fd6c86beee1 100644 > --- a/fs/zonefs/super.c > +++ b/fs/zonefs/super.c > @@ -1297,7 +1297,7 @@ static int zonefs_read_super(struct super_block *sb) > if (ret) > goto free_page; > > - super = kmap(page); > + super = kmap_thread(page); > > ret = -EINVAL; > if (le32_to_cpu(super->s_magic) != ZONEFS_MAGIC) > @@ -1349,7 +1349,7 @@ static int zonefs_read_super(struct super_block *sb) > ret = 0; > > unmap: > - kunmap(page); > + kunmap_thread(page); > free_page: > __free_page(page); > > acked-by: Damien Le Moal -- Damien Le Moal Western Digital Research